Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759711Ab3FCSar (ORCPT ); Mon, 3 Jun 2013 14:30:47 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:38738 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754989Ab3FCSaq (ORCPT ); Mon, 3 Jun 2013 14:30:46 -0400 Date: Mon, 3 Jun 2013 11:30:45 -0700 From: Greg Kroah-Hartman To: Ben Chan Cc: devel@driverdev.osuosl.org, Sage Ahn , linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: gdm72xx: WIMAX_GDM72XX should depend on either USB or MMC Message-ID: <20130603183044.GA10608@kroah.com> References: <1370280225-27479-1-git-send-email-benchan@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1370280225-27479-1-git-send-email-benchan@chromium.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1165 Lines: 35 On Mon, Jun 03, 2013 at 10:23:45AM -0700, Ben Chan wrote: > The gdm72xx driver needs to have either the USB or SDIO implementation > enabled to provide useful functionalities, so the driver should depend > on either USB or MMC. > > Signed-off-by: Ben Chan > Cc: Sage Ahn > --- > drivers/staging/gdm72xx/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/gdm72xx/Kconfig b/drivers/staging/gdm72xx/Kconfig > index 6905913..8af0dd4 100644 > --- a/drivers/staging/gdm72xx/Kconfig > +++ b/drivers/staging/gdm72xx/Kconfig > @@ -4,7 +4,7 @@ > > menuconfig WIMAX_GDM72XX > tristate "GCT GDM72xx WiMAX support" > - depends on NET > + depends on NET && (USB || MMC) Really? Again? Are you trying to just get me to ignore your patches? If so, you just did a good job, please take a day or two to relax and get it right. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/