Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759631Ab3FCSxC (ORCPT ); Mon, 3 Jun 2013 14:53:02 -0400 Received: from merlin.infradead.org ([205.233.59.134]:36851 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755384Ab3FCSw7 (ORCPT ); Mon, 3 Jun 2013 14:52:59 -0400 Date: Mon, 3 Jun 2013 20:52:28 +0200 From: Peter Zijlstra To: Johannes Weiner Cc: linux-mm@kvack.org, Andi Kleen , Andrea Arcangeli , Andrew Morton , Greg Thelen , Christoph Hellwig , Hugh Dickins , Jan Kara , KOSAKI Motohiro , Mel Gorman , Minchan Kim , Rik van Riel , Michel Lespinasse , Seth Jennings , Roman Gushchin , metin d , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [patch 10/10] mm: workingset: keep shadow entries in check Message-ID: <20130603185228.GG8923@twins.programming.kicks-ass.net> References: <1369937046-27666-1-git-send-email-hannes@cmpxchg.org> <1369937046-27666-11-git-send-email-hannes@cmpxchg.org> <20130603082533.GH5910@twins.programming.kicks-ass.net> <20130603152032.GF15576@cmpxchg.org> <20130603171558.GE8923@twins.programming.kicks-ass.net> <20130603181202.GI15576@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130603181202.GI15576@cmpxchg.org> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 944 Lines: 21 On Mon, Jun 03, 2013 at 02:12:02PM -0400, Johannes Weiner wrote: > > But given that, sure maybe 1 memory size is a bit strict, but surely we > > can put a limit on things at about 2 memory sizes? > > That's what this 10/10 patch does (prune everything older than 2 * > global_dirtyable_memory()), so I think we're talking past each other. > > Maybe the wording of the changelog was confusing? The paragraph you > quoted above explains the problem resulting from 9/10 but which this > patch 10/10 fixes. Could be I just didn't read very well -- I pretty much raced through the patches trying to get a general overview and see if I could spot something weird. I'll try again and let you know :-) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/