Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758345Ab3FCUtd (ORCPT ); Mon, 3 Jun 2013 16:49:33 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:59158 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754765Ab3FCUtc (ORCPT ); Mon, 3 Jun 2013 16:49:32 -0400 Date: Mon, 3 Jun 2013 13:49:30 -0700 From: Christoph Hellwig To: Joern Engel Cc: linux-kernel@vger.kernel.org, Chris Mason , linux-btrfs@vger.kernel.org Subject: Re: [PATCH 0/2] introduce list_for_each_entry_del Message-ID: <20130603204930.GA28299@infradead.org> References: <1370280485-10047-1-git-send-email-joern@logfs.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1370280485-10047-1-git-send-email-joern@logfs.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 434 Lines: 11 I can't say I like the structure. A list_pop that removes and entry from the head or returns NULL if the list is empty would lead to nice while loops that are obviously readable instead. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/