Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759638Ab3FDBvo (ORCPT ); Mon, 3 Jun 2013 21:51:44 -0400 Received: from mga11.intel.com ([192.55.52.93]:16082 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758531Ab3FDBvm (ORCPT ); Mon, 3 Jun 2013 21:51:42 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.87,796,1363158000"; d="scan'208";a="347597143" Message-ID: <51AD4808.6020507@intel.com> Date: Tue, 04 Jun 2013 09:51:04 +0800 From: Alex Shi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130329 Thunderbird/17.0.5 MIME-Version: 1.0 To: Peter Zijlstra CC: Paul Turner , Ingo Molnar , Thomas Gleixner , Andrew Morton , Borislav Petkov , Namhyung Kim , Mike Galbraith , Morten Rasmussen , Vincent Guittot , Preeti U Murthy , Viresh Kumar , LKML , Mel Gorman , Rik van Riel , Michael Wang Subject: [DISCUSSION] removing variety rq->cpu_load ? References: <1367804711-30308-1-git-send-email-alex.shi@intel.com> <1367804711-30308-6-git-send-email-alex.shi@intel.com> <20130506101936.GE13861@dyad.programming.kicks-ass.net> <20130506111041.GA15446@dyad.programming.kicks-ass.net> <51889C8A.5000806@intel.com> <51AD46CA.9020609@intel.com> In-Reply-To: <51AD46CA.9020609@intel.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1399 Lines: 39 resend with a new subject. > Peter, > > I just tried to remove the variety rq.cpu_load, by the following patch. > Because forkexec_idx and busy_idx are all zero, after the patch system just keep cpu_load[0] > and remove other values. > I tried the patch base 3.10-rc3 and latest tip/sched/core with benchmark dbench,tbench, > aim7,hackbench. and oltp of sysbench. Seems performance doesn't change clear. > So, for my tested machines, core2, NHM, SNB, with 2 or 4 CPU sockets, and above tested > benchmark. We are fine to remove the variety cpu_load. > Don't know if there some other concerns on other scenarios. > > --- > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > index 590d535..f0ca983 100644 > --- a/kernel/sched/fair.c > +++ b/kernel/sched/fair.c > @@ -4626,7 +4626,7 @@ static inline void update_sd_lb_stats(struct lb_env *env, > if (child && child->flags & SD_PREFER_SIBLING) > prefer_sibling = 1; > > - load_idx = get_sd_load_idx(env->sd, env->idle); > + load_idx = 0; //get_sd_load_idx(env->sd, env->idle); > > do { > int local_group; > > -- Thanks Alex -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/