Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753907Ab3FDEsw (ORCPT ); Tue, 4 Jun 2013 00:48:52 -0400 Received: from mail-ie0-f175.google.com ([209.85.223.175]:52456 "EHLO mail-ie0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750972Ab3FDEsu convert rfc822-to-8bit (ORCPT ); Tue, 4 Jun 2013 00:48:50 -0400 MIME-Version: 1.0 In-Reply-To: <51961B09.6030201@samsung.com> References: <1368525540-15034-1-git-send-email-amit.daniel@samsung.com> <1368525540-15034-11-git-send-email-amit.daniel@samsung.com> <51961B09.6030201@samsung.com> Date: Tue, 4 Jun 2013 10:18:49 +0530 X-Google-Sender-Auth: 98-24eeCX-F6zMMsk2sw4TAEFxQ Message-ID: Subject: Re: [PATCH V4 10/30] thermal: exynos: Support thermal tripping From: amit daniel kachhap To: jonghwa3.lee@samsung.com Cc: linux-pm@vger.kernel.org, Zhang Rui , linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Kukjin Kim , Eduardo Valentin Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 4010 Lines: 96 Hi . On Fri, May 17, 2013 at 5:26 PM, wrote: > Hi, Amit > On 2013년 05월 14일 18:58, Amit Daniel Kachhap wrote: > >> TMU urgently sends active-high signal (thermal trip) to PMU, and thermal >> tripping by hardware logic. Thermal tripping means that PMU cuts off the >> whole power of SoC by controlling external voltage regulator. >> >> Acked-by: Kukjin Kim >> Signed-off-by: Jonghwan Choi >> Signed-off-by: Amit Daniel Kachhap >> --- >> drivers/thermal/samsung/exynos_tmu.c | 8 +++++++- >> drivers/thermal/samsung/exynos_tmu_data.c | 2 ++ >> 2 files changed, 9 insertions(+), 1 deletions(-) >> >> diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c >> index 5f8f189..479d61e 100644 >> --- a/drivers/thermal/samsung/exynos_tmu.c >> +++ b/drivers/thermal/samsung/exynos_tmu.c >> @@ -84,6 +84,7 @@ >> #define EXYNOS_TMU_CLEAR_FALL_INT (0x111 << 12) >> #define EXYNOS_TMU_TRIP_MODE_SHIFT 13 >> #define EXYNOS_TMU_TRIP_MODE_MASK 0x7 >> +#define EXYNOS_TMU_THERM_TRIP_EN_SHIFT 12 >> >> #define EXYNOS_TMU_INTEN_RISE0_SHIFT 0 >> #define EXYNOS_TMU_INTEN_RISE1_SHIFT 4 >> @@ -186,7 +187,7 @@ static int exynos_tmu_initialize(struct platform_device *pdev) >> { >> struct exynos_tmu_data *data = platform_get_drvdata(pdev); >> struct exynos_tmu_platform_data *pdata = data->pdata; >> - unsigned int status, trim_info; >> + unsigned int status, trim_info, con; >> unsigned int rising_threshold = 0, falling_threshold = 0; >> int ret = 0, threshold_code, i, trigger_levs = 0; >> >> @@ -251,6 +252,11 @@ static int exynos_tmu_initialize(struct platform_device *pdev) >> falling_threshold |= >> threshold_code << 8 * i; >> } >> + if (pdata->trigger_type[i] != HW_TRIP) >> + continue; > > > As you know, HW trip can be used when only the most last level of threshold > temperature is set. (exynos4412 : 4th, exynos 5440 : 5th threshold level). So it > wouldn't work properly, even if we enable HW trip according to pre-defined > trigger type not to HW trip threshold temperature. To enable HW trip, we just > need to check whether if HW trip threshold temperature level is defined. > > if (trigger_level[HW_TRIP_LEVEL]) > enable HW trip Yes you are right. I will include this change in the next version. Thanks, Amit Daniel > > Thanks, > Jonghwa > >> + con = readl(data->base + EXYNOS_TMU_REG_CONTROL); >> + con |= (1 << EXYNOS_TMU_THERM_TRIP_EN_SHIFT); >> + writel(con, data->base + EXYNOS_TMU_REG_CONTROL); >> } >> >> writel(rising_threshold, >> diff --git a/drivers/thermal/samsung/exynos_tmu_data.c b/drivers/thermal/samsung/exynos_tmu_data.c >> index ee6a3c9..6b937f5 100644 >> --- a/drivers/thermal/samsung/exynos_tmu_data.c >> +++ b/drivers/thermal/samsung/exynos_tmu_data.c >> @@ -64,6 +64,7 @@ struct exynos_tmu_platform_data const exynos5250_default_tmu_data = { >> .trigger_levels[0] = 85, >> .trigger_levels[1] = 103, >> .trigger_levels[2] = 110, >> + .trigger_levels[3] = 120, >> .trigger_enable[0] = 1, >> .trigger_enable[1] = 1, >> .trigger_enable[2] = 1, >> @@ -71,6 +72,7 @@ struct exynos_tmu_platform_data const exynos5250_default_tmu_data = { >> .trigger_type[0] = 0, >> .trigger_type[1] = 0, >> .trigger_type[2] = 1, >> + .trigger_type[3] = 2, >> .gain = 8, >> .reference_voltage = 16, >> .noise_cancel_mode = 4, > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/