Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759191Ab3FDGer (ORCPT ); Tue, 4 Jun 2013 02:34:47 -0400 Received: from mail-ob0-f171.google.com ([209.85.214.171]:38711 "EHLO mail-ob0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752834Ab3FDGep convert rfc822-to-8bit (ORCPT ); Tue, 4 Jun 2013 02:34:45 -0400 MIME-Version: 1.0 In-Reply-To: <201306030056.03522.heiko@sntech.de> References: <201306030055.15413.heiko@sntech.de> <201306030056.03522.heiko@sntech.de> Date: Tue, 4 Jun 2013 08:34:44 +0200 Message-ID: Subject: Re: [PATCH 01/10] clocksource: dw_apb_timer_of: use the clocksource as sched clock if necessary From: Linus Walleij To: =?ISO-8859-1?Q?Heiko_St=FCbner?= Cc: "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , John Stultz , Thomas Gleixner , Mike Turquette , Seungwon Jeon , Jaehoon Chung , Chris Ball , "linux-mmc@vger.kernel.org" , Grant Likely , Rob Herring , "devicetree-discuss@lists.ozlabs.org" , Russell King , Arnd Bergmann , Olof Johansson Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 999 Lines: 23 On Mon, Jun 3, 2013 at 12:56 AM, Heiko St?bner wrote: > Currently the dw_apb_timer always expects a separate special timer to be > availbable for the sched_clock. Some devices using dw_apb_timers do not > have the sptimer but can use the clocksource as sched_clock. > Therefore this patch adds using the clocksource timer as > a fallback if no usable sched timer is found. > > Signed-off-by: Heiko Stuebner Is this really what the patch does? I mean "ass the clocksourse as fallback", it seems more like that is controlled from the device tree, this looks more like some more careful handling of the device tree input making the sched_timer optional, it doesn't really "add" anything, does it? Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/