Return-Path: <linux-kernel-owner+willy=40w.ods.org@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id <S263188AbSJBQrH>; Wed, 2 Oct 2002 12:47:07 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org
	id <S263191AbSJBQrH>; Wed, 2 Oct 2002 12:47:07 -0400
Received: from cerebus.wirex.com ([65.102.14.138]:51952 "EHLO
	figure1.int.wirex.com") by vger.kernel.org with ESMTP
	id <S263188AbSJBQqV>; Wed, 2 Oct 2002 12:46:21 -0400
Date: Wed, 2 Oct 2002 09:44:17 -0700
From: Chris Wright <chris@wirex.com>
To: Robert Love <rml@tech9.net>
Cc: Daniel Jacobowitz <dan@debian.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Re: Capabilities-related change in 2.5.40
Message-ID: <20021002094417.D26557@figure1.int.wirex.com>
Mail-Followup-To: Robert Love <rml@tech9.net>,
	Daniel Jacobowitz <dan@debian.org>, linux-kernel@vger.kernel.org
References: <20021001164907.GA25307@nevyn.them.org> <20021001134552.A26557@figure1.int.wirex.com> <20021001211210.GA8784@nevyn.them.org> <20021002003817.B26557@figure1.int.wirex.com> <20021002132331.GA17376@nevyn.them.org> <1033569212.24108.20.camel@phantasy>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
In-Reply-To: <1033569212.24108.20.camel@phantasy>; from rml@tech9.net on Wed, Oct 02, 2002 at 10:33:32AM -0400
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1199
Lines: 31

* Robert Love (rml@tech9.net) wrote:
> On Wed, 2002-10-02 at 09:23, Daniel Jacobowitz wrote:
> 
> > How very odd.  I have been running 2.5 on that machine for a while, and
> > the bug only showed up somewhere between 2.5.36 and 2.5.40.  Maybe a
> > coincidence triggered by the PID hashing... your tabbing is a little
> > odd but the patch looks right to me.  Thanks!
> 
> I too wonder if the bug is due to the pid changes and not me :)

No way man! ;-)

> find_task_by_pid(0) should just return current, which was my intention
> to avoid conditional code-paths.  Maybe I should of used
> find_process_by_pid()... it seems in the latest 2.5 that still returns
> current if !pid, at least.

kernel/sched.c::static inline task_t *find_process_by_pid...

Guess that won't work w/out more changes.  Perhaps it's simpler/safer
to be just be explicit in this case.

thanks,
-chris
-- 
Linux Security Modules     http://lsm.immunix.org     http://lsm.bkbits.net
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/