Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759905Ab3FDHdl (ORCPT ); Tue, 4 Jun 2013 03:33:41 -0400 Received: from mail-we0-f175.google.com ([74.125.82.175]:63642 "EHLO mail-we0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759292Ab3FDHdk (ORCPT ); Tue, 4 Jun 2013 03:33:40 -0400 Date: Tue, 4 Jun 2013 08:33:35 +0100 From: Lee Jones To: Stephen Boyd Cc: Samuel Ortiz , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, David Brown Subject: Re: [PATCHv2 2/2] mfd: ssbi: Use devm_* and simplify code Message-ID: <20130604073335.GK3370@gmail.com> References: <1370288384-3122-1-git-send-email-sboyd@codeaurora.org> <1370288384-3122-2-git-send-email-sboyd@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1370288384-3122-2-git-send-email-sboyd@codeaurora.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 956 Lines: 27 On Mon, 03 Jun 2013, Stephen Boyd wrote: > Use devm_ioremap_resource and devm_kzalloc to simplify error > paths and reduce lines of code. Also use dev_err() to keep > consistency and drop the .remove function because the devm > functions take care of what it's doing besides the now obsolete > platform_set_drvdata() which we can just drop. Finally, use > module_platform_driver() to save some more lines. > > Cc: David Brown > Signed-off-by: Stephen Boyd > --- Really nice. Acked-by: Lee Jones -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/