Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751496Ab3FDI3x (ORCPT ); Tue, 4 Jun 2013 04:29:53 -0400 Received: from gloria.sntech.de ([95.129.55.99]:56805 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750982Ab3FDI3u (ORCPT ); Tue, 4 Jun 2013 04:29:50 -0400 From: Heiko =?iso-8859-1?q?St=FCbner?= To: Linus Walleij Subject: Re: [PATCH 01/10] clocksource: dw_apb_timer_of: use the clocksource as sched clock if necessary Date: Tue, 4 Jun 2013 10:29:38 +0200 User-Agent: KMail/1.13.7 (Linux/3.2.0-3-686-pae; KDE/4.8.4; i686; ; ) Cc: "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , John Stultz , Thomas Gleixner , Mike Turquette , Seungwon Jeon , Jaehoon Chung , Chris Ball , "linux-mmc@vger.kernel.org" , Grant Likely , Rob Herring , "devicetree-discuss@lists.ozlabs.org" , Russell King , Arnd Bergmann , Olof Johansson References: <201306030055.15413.heiko@sntech.de> <201306030056.03522.heiko@sntech.de> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 8bit Message-Id: <201306041029.39053.heiko@sntech.de> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1603 Lines: 33 Am Dienstag, 4. Juni 2013, 08:34:44 schrieb Linus Walleij: > On Mon, Jun 3, 2013 at 12:56 AM, Heiko St?bner wrote: > > Currently the dw_apb_timer always expects a separate special timer to be > > availbable for the sched_clock. Some devices using dw_apb_timers do not > > have the sptimer but can use the clocksource as sched_clock. > > Therefore this patch adds using the clocksource timer as > > a fallback if no usable sched timer is found. > > > > Signed-off-by: Heiko Stuebner > > Is this really what the patch does? I mean "ass the clocksourse as > fallback", it seems more like that is controlled from the device tree, > this looks more like some more careful handling of the device tree > input making the sched_timer optional, it doesn't really "add" > anything, does it? Right, the commit message is probably based a bit to much on the before-state of the driver, always expecting the "sptimer" and panicing if not found. How about: Currently the dw_apb_timer always expects a separate special timer to be availbable for the sched_clock. Some devices using dw_apb_timers do not have this sptimer but can use the clocksource as sched_clock instead. Therefore enable the driver to distiguish between devices with and without sptimer based on the devicetree data and select the correct timer as sched_clock. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/