Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752978Ab3FDJxX (ORCPT ); Tue, 4 Jun 2013 05:53:23 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:54075 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751210Ab3FDJxV convert rfc822-to-8bit (ORCPT ); Tue, 4 Jun 2013 05:53:21 -0400 From: "Hebbar, Gururaja" To: Linus Walleij CC: Kevin Hilman , Grant Likely , Rob Herring , "davinci-linux-open-source@linux.davincidsp.com" , "devicetree-discuss@lists.ozlabs.org" , "linux-arm-kernel@lists.infradead.org" , Russell King - ARM Linux , "linux-kernel@vger.kernel.org" , "Bedia, Vaibhav" , "Rajashekhara, Sudhakar" , "Krishnamoorthy, Balaji T" , Chris Ball , "linux-mmc@vger.kernel.org" , Linux-OMAP Subject: RE: [PATCH 09/11] mmc: omap_hsmmc: enhance pinctrl support Thread-Topic: [PATCH 09/11] mmc: omap_hsmmc: enhance pinctrl support Thread-Index: AQHOXec2AO2evZO3OEW2xoUxyV4ly5kko2oAgAACgICAALCzkA== Date: Tue, 4 Jun 2013 09:52:42 +0000 Message-ID: <1BAFE6F6C881BF42822005164F1491C33EC2235F@DBDE04.ent.ti.com> References: <1369995191-20855-1-git-send-email-gururaja.hebbar@ti.com> <1369995191-20855-10-git-send-email-gururaja.hebbar@ti.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.24.170.142] Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1870 Lines: 51 On Tue, Jun 04, 2013 at 12:49:57, Linus Walleij wrote: > On Tue, Jun 4, 2013 at 9:11 AM, Linus Walleij wrote: > > On Fri, May 31, 2013 at 12:13 PM, Hebbar Gururaja > > wrote: > > > >> Amend the hsmmc controller to optionally take a pin control handle and > >> set the state of the pins to: > >> > >> - "default" on boot, resume and before performing a mmc transfer > >> - "idle" after initial default, after resume default, and after each > >> mmc/sd card access > >> - "sleep" on suspend() > >> > >> By optionally putting the pins into sleep state in the suspend callback > >> we can accomplish two things. > >> - One is to minimize current leakage from pins and thus save power, > >> - second, we can prevent the IP from driving pins output in an > >> uncontrolled manner, which may happen if the power domain drops the > >> domain regulator. > >> > >> If any of the above pin states are missing in dt, a warning message > >> about the missing state is displayed. > >> If certain pin-states are not available, to remove this warning message > >> pass respective state name with null phandler. > >> > >> Signed-off-by: Hebbar Gururaja > >> Cc: Balaji T K > >> Cc: Chris Ball > >> Cc: linux-mmc@vger.kernel.org > >> Cc: linux-omap@vger.kernel.org > > > > This is perfectly correct. > > Acked-by: Linus Walleij > > So please consider my other option given in patch 2 instead. I will check how I can be a part of this implementation > > Yours, > Linus Walleij > Regards, Gururaja -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/