Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754939Ab3FDNJ1 (ORCPT ); Tue, 4 Jun 2013 09:09:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:21892 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751733Ab3FDNJX (ORCPT ); Tue, 4 Jun 2013 09:09:23 -0400 Message-ID: <51ADE6F1.90709@redhat.com> Date: Tue, 04 Jun 2013 15:09:05 +0200 From: Jerome Marchand User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Jiang Liu CC: Greg Kroah-Hartman , Nitin Gupta , Minchan Kim , Yijing Wang , Jiang Liu , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH v1 1/8] zram: simplify and optimize zram_to_dev() References: <1370274140-26420-1-git-send-email-jiang.liu@huawei.com> <1370274140-26420-2-git-send-email-jiang.liu@huawei.com> In-Reply-To: <1370274140-26420-2-git-send-email-jiang.liu@huawei.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1390 Lines: 47 Hi, Please write a commit message, no matter how straightforward a patch may seem to you. Also the subject suffers from dyslexia: it's dev_to_zram, not zram_to_dev. Thanks, Jerome On 06/03/2013 05:42 PM, Jiang Liu wrote: > Signed-off-by: Jiang Liu > --- > drivers/staging/zram/zram_sysfs.c | 13 ++----------- > 1 file changed, 2 insertions(+), 11 deletions(-) > > diff --git a/drivers/staging/zram/zram_sysfs.c b/drivers/staging/zram/zram_sysfs.c > index e6a929d..8cb7822 100644 > --- a/drivers/staging/zram/zram_sysfs.c > +++ b/drivers/staging/zram/zram_sysfs.c > @@ -30,18 +30,9 @@ static u64 zram_stat64_read(struct zram *zram, u64 *v) > return val; > } > > -static struct zram *dev_to_zram(struct device *dev) > +static inline struct zram *dev_to_zram(struct device *dev) > { > - int i; > - struct zram *zram = NULL; > - > - for (i = 0; i < zram_get_num_devices(); i++) { > - zram = &zram_devices[i]; > - if (disk_to_dev(zram->disk) == dev) > - break; > - } > - > - return zram; > + return (struct zram *)dev_to_disk(dev)->private_data; > } > > static ssize_t disksize_show(struct device *dev, > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/