Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754986Ab3FDOb1 (ORCPT ); Tue, 4 Jun 2013 10:31:27 -0400 Received: from mail-pa0-f41.google.com ([209.85.220.41]:48966 "EHLO mail-pa0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753197Ab3FDObZ (ORCPT ); Tue, 4 Jun 2013 10:31:25 -0400 Message-ID: <51ADFA36.7080405@gmail.com> Date: Tue, 04 Jun 2013 22:31:18 +0800 From: Jiang Liu User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130404 Thunderbird/17.0.5 MIME-Version: 1.0 To: Jerome Marchand CC: Greg Kroah-Hartman , Nitin Gupta , Minchan Kim , Yijing Wang , Jiang Liu , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH v1 1/8] zram: simplify and optimize zram_to_dev() References: <1370274140-26420-1-git-send-email-jiang.liu@huawei.com> <1370274140-26420-2-git-send-email-jiang.liu@huawei.com> <51ADE6F1.90709@redhat.com> In-Reply-To: <51ADE6F1.90709@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1573 Lines: 54 On Tue 04 Jun 2013 09:09:05 PM CST, Jerome Marchand wrote: > Hi, > > Please write a commit message, no matter how straightforward a patch may > seem to you. > Also the subject suffers from dyslexia: it's dev_to_zram, not zram_to_dev. > > Thanks, > Jerome Hi Jerome, Thanks for review, will fix it in next version. Regards! Gerry > > On 06/03/2013 05:42 PM, Jiang Liu wrote: >> Signed-off-by: Jiang Liu >> --- >> drivers/staging/zram/zram_sysfs.c | 13 ++----------- >> 1 file changed, 2 insertions(+), 11 deletions(-) >> >> diff --git a/drivers/staging/zram/zram_sysfs.c b/drivers/staging/zram/zram_sysfs.c >> index e6a929d..8cb7822 100644 >> --- a/drivers/staging/zram/zram_sysfs.c >> +++ b/drivers/staging/zram/zram_sysfs.c >> @@ -30,18 +30,9 @@ static u64 zram_stat64_read(struct zram *zram, u64 *v) >> return val; >> } >> >> -static struct zram *dev_to_zram(struct device *dev) >> +static inline struct zram *dev_to_zram(struct device *dev) >> { >> - int i; >> - struct zram *zram = NULL; >> - >> - for (i = 0; i < zram_get_num_devices(); i++) { >> - zram = &zram_devices[i]; >> - if (disk_to_dev(zram->disk) == dev) >> - break; >> - } >> - >> - return zram; >> + return (struct zram *)dev_to_disk(dev)->private_data; >> } >> >> static ssize_t disksize_show(struct device *dev, >> > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/