Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756883Ab3FDPGM (ORCPT ); Tue, 4 Jun 2013 11:06:12 -0400 Received: from sema.semaphore.gr ([78.46.194.137]:57956 "EHLO sema.semaphore.gr" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1752522Ab3FDPGJ (ORCPT ); Tue, 4 Jun 2013 11:06:09 -0400 Message-ID: <51AE025C.9030401@semaphore.gr> Date: Tue, 04 Jun 2013 18:06:04 +0300 From: Stratos Karafotis User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6 MIME-Version: 1.0 To: Viresh Kumar CC: "Rafael J. Wysocki" , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , linux-pm@vger.kernel.org, cpufreq@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/3] cpufreq: Remove unused function __cpufreq_driver_getavg References: <51ACF2F1.1050600@semaphore.gr> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1711 Lines: 47 On 06/04/2013 08:19 AM, Viresh Kumar wrote: > On 4 June 2013 01:18, Stratos Karafotis wrote: >> Calculation of frequency target in ondemand governor changed and it is > > s/frequency target/target frequency I will change it also in 3/3 that I use the same. >> independent from measured average frequency. >> >> Remove unused__cpufreq_driver_getavg function and getavg member from >> cpufreq_driver struct. Also, remove the callback getavg in >> acpi_cpufreq_driver. >> >> Signed-off-by: Stratos Karafotis >> --- >> drivers/cpufreq/Makefile | 2 +- >> drivers/cpufreq/acpi-cpufreq.c | 5 ----- >> drivers/cpufreq/cpufreq.c | 12 ------------ >> include/linux/cpufreq.h | 6 ------ >> 4 files changed, 1 insertion(+), 24 deletions(-) >> >> diff --git a/drivers/cpufreq/Makefile b/drivers/cpufreq/Makefile >> index 6ad0b91..aebd4ef 100644 >> --- a/drivers/cpufreq/Makefile >> +++ b/drivers/cpufreq/Makefile >> @@ -23,7 +23,7 @@ obj-$(CONFIG_GENERIC_CPUFREQ_CPU0) += cpufreq-cpu0.o >> # powernow-k8 can load then. ACPI is preferred to all other hardware-specific drivers. >> # speedstep-* is preferred over p4-clockmod. >> >> -obj-$(CONFIG_X86_ACPI_CPUFREQ) += acpi-cpufreq.o mperf.o > > Should this be done in 3/3 ? > acpi-cpufreq does not use mperf after 2/3. Why should we compile it with CONFIG_X86_ACPI_CPUFREQ? Do you want me to move the change in 3/3? Thanks, Stratos -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/