Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751276Ab3FDSQa (ORCPT ); Tue, 4 Jun 2013 14:16:30 -0400 Received: from caramon.arm.linux.org.uk ([78.32.30.218]:35362 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751037Ab3FDSQ1 (ORCPT ); Tue, 4 Jun 2013 14:16:27 -0400 Date: Tue, 4 Jun 2013 19:16:08 +0100 From: Russell King - ARM Linux To: John Stultz Cc: Stephen Boyd , Baruch Siach , linux-arm-msm@vger.kernel.org, Will Deacon , linux-kernel@vger.kernel.org, arm@kernel.org, Catalin Marinas , Thomas Gleixner , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCHv2 3/6] sched_clock: Make ARM's sched_clock generic for all architectures Message-ID: <20130604181608.GB18614@n2100.arm.linux.org.uk> References: <1370155183-31421-1-git-send-email-sboyd@codeaurora.org> <1370155183-31421-4-git-send-email-sboyd@codeaurora.org> <20130603071235.GO11798@tarshish> <51ACF374.5040606@codeaurora.org> <51AE2A30.4010903@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <51AE2A30.4010903@linaro.org> User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1260 Lines: 26 On Tue, Jun 04, 2013 at 10:56:00AM -0700, John Stultz wrote: > On 06/03/2013 12:50 PM, Stephen Boyd wrote: >> On 06/03/13 00:12, Baruch Siach wrote: >>> Hi Stephen, >>> >>> On Sat, Jun 01, 2013 at 11:39:40PM -0700, Stephen Boyd wrote: >>>> {arch/arm/include/asm => include/linux}/sched_clock.h | 9 +++++++-- >>> Shouldn't we just merge this header into the existing linux/sched.h? >> I don't know. John/Thomas, any thoughts? One benefit with it this way is >> that we don't have to recompile all the timer drivers if we change >> sched.h for other reasons. > > Yea, I'm fine keeping it separate for now. We can merge them together if > we see fit later. > > But if anyone feels particularly strongly, let me know. I'd suggest keeping it separate. linux/sched.h is already a big source of rebuilds because it's included by virtually the entire kernel. Having linux/sched.h carved up into smaller chunks (maybe moving the definition of task_struct and associated bits out of it) would probably be a good idea. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/