Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752072Ab3FEGkR (ORCPT ); Wed, 5 Jun 2013 02:40:17 -0400 Received: from LGEMRELSE1Q.lge.com ([156.147.1.111]:45696 "EHLO LGEMRELSE1Q.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751268Ab3FEGkO (ORCPT ); Wed, 5 Jun 2013 02:40:14 -0400 X-AuditID: 9c93016f-b7ba8ae000004f01-16-51aedd4ce0eb Date: Wed, 5 Jun 2013 15:40:12 +0900 From: Minchan Kim To: Jiang Liu Cc: Greg Kroah-Hartman , Nitin Gupta , Jerome Marchand , Yijing Wang , Jiang Liu , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 04/10] zram: destroy all devices on error recovery path in zram_init() Message-ID: <20130605064012.GD8732@blaptop> References: <1370361968-8764-1-git-send-email-jiang.liu@huawei.com> <1370361968-8764-4-git-send-email-jiang.liu@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1370361968-8764-4-git-send-email-jiang.liu@huawei.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Brightmail-Tracker: AAAAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 627 Lines: 17 On Wed, Jun 05, 2013 at 12:06:02AM +0800, Jiang Liu wrote: > On error recovery path of zram_init(), it leaks the zram device object > causing the failure. So change create_device() to free allocated > resources on error path. > > Signed-off-by: Jiang Liu > Cc: stable@vger.kernel.org Acked-by: Minchan Kim -- Kind regards, Minchan Kim -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/