Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752542Ab3FEHjp (ORCPT ); Wed, 5 Jun 2013 03:39:45 -0400 Received: from e28smtp07.in.ibm.com ([122.248.162.7]:59186 "EHLO e28smtp07.in.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751743Ab3FEHjo (ORCPT ); Wed, 5 Jun 2013 03:39:44 -0400 Message-ID: <51AEEB37.1070403@linux.vnet.ibm.com> Date: Wed, 05 Jun 2013 15:39:35 +0800 From: Michael Wang User-Agent: Mozilla/5.0 (X11; Linux i686; rv:16.0) Gecko/20121011 Thunderbird/16.0.1 MIME-Version: 1.0 To: Tejun Heo , LKML Subject: Re: [PATCH 0/3] workqueue: code refine/clean for workqueue References: <51AEE452.8080605@linux.vnet.ibm.com> In-Reply-To: <51AEE452.8080605@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-TM-AS-MML: No X-Content-Scanned: Fidelis XPS MAILER x-cbid: 13060507-8878-0000-0000-00000767B756 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1061 Lines: 33 On 06/05/2013 03:10 PM, Michael Wang wrote: > Code refine/clean patch set for workqueue. > > Michael Wang (3): > [PATCH 1/3] workqueue: move the internal helper from .h to .c > [PATCH 2/3] workqueue: remove the unused helper in .h > [PATCH 3/3] workqueue: add a check point in pwq_activate_delayed_work() Hi, Tejun Sounds like I failed to grasp the essentials of the way we maintain workqueue :( These are just self opinion I got during the review, please ignore them if they will cause trouble to your maintain work :) Regards, Michael Wang > > --- > b/include/linux/workqueue.h | 5 ----- > b/kernel/workqueue.c | 5 +++++ > include/linux/workqueue.h | 27 --------------------------- > kernel/workqueue.c | 6 +++--- > 4 files changed, 8 insertions(+), 35 deletions(-) > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/