Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752848Ab3FEINA (ORCPT ); Wed, 5 Jun 2013 04:13:00 -0400 Received: from e23smtp02.au.ibm.com ([202.81.31.144]:46211 "EHLO e23smtp02.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752500Ab3FEIM5 (ORCPT ); Wed, 5 Jun 2013 04:12:57 -0400 Message-ID: <51AEF2FD.2020007@linux.vnet.ibm.com> Date: Wed, 05 Jun 2013 16:12:45 +0800 From: Michael Wang User-Agent: Mozilla/5.0 (X11; Linux i686; rv:16.0) Gecko/20121011 Thunderbird/16.0.1 MIME-Version: 1.0 To: Jiri Kosina CC: Borislav Petkov , "Paul E. McKenney" , Frederic Weisbecker , Tony Luck , linux-kernel@vger.kernel.org, x86@kernel.org, Thomas Gleixner Subject: Re: NOHZ: WARNING: at arch/x86/kernel/smp.c:123 native_smp_send_reschedule, round 2 References: <20130509125040.GF27333@pd.tnic> <20130509125859.GG27333@pd.tnic> <20130515184528.GO4442@linux.vnet.ibm.com> <20130515224358.GF11783@pd.tnic> <20130515235512.GT4442@linux.vnet.ibm.com> <20130517135641.GF23035@pd.tnic> <51AEA2A8.90605@linux.vnet.ibm.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Content-Scanned: Fidelis XPS MAILER x-cbid: 13060508-5490-0000-0000-0000039688E9 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1606 Lines: 57 On 06/05/2013 04:08 PM, Jiri Kosina wrote: > On Wed, 5 Jun 2013, Michael Wang wrote: > >>> Just to not let this thread sleep -- I am seeing this as well, even with >>> current Linus' tree (git HEAD == aa4f608). >> >> Have you tried this: >> >> diff --git a/drivers/cpufreq/cpufreq_governor.c >> b/drivers/cpufreq/cpufreq_governor.c >> index 443442d..449be88 100644 >> --- a/drivers/cpufreq/cpufreq_governor.c >> +++ b/drivers/cpufreq/cpufreq_governor.c >> @@ -26,6 +26,7 @@ >> #include >> #include >> #include >> +#include >> >> #include "cpufreq_governor.h" >> >> @@ -180,8 +181,10 @@ void gov_queue_work(struct dbs_data *dbs_data, >> struct cpufreq_policy *policy, >> if (!all_cpus) { >> __gov_queue_work(smp_processor_id(), dbs_data, delay); >> } else { >> + get_online_cpus(); >> for_each_cpu(i, policy->cpus) >> __gov_queue_work(i, dbs_data, delay); >> + put_online_cpus(); >> } >> } >> EXPORT_SYMBOL_GPL(gov_queue_work); >> >> Does it works? > > Yes, the warning is gone with this patch. Nice, so I think we proved that 'policy->cpus' is well maintained. > > Tested-by: Jiri Kosina Thanks for your testing :) Regards, Michael Wang > > Thanks, > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/