Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755495Ab3FEM2t (ORCPT ); Wed, 5 Jun 2013 08:28:49 -0400 Received: from hydra.sisk.pl ([212.160.235.94]:58355 "EHLO hydra.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755220Ab3FEM2r (ORCPT ); Wed, 5 Jun 2013 08:28:47 -0400 From: "Rafael J. Wysocki" To: Michael Wang Cc: Viresh Kumar , cpufreq@vger.kernel.org, linux-pm@vger.kernel.org, LKML , Jiri Kosina , Borislav Petkov , Frederic Weisbecker , "tony.luck@intel.com" , Thomas Gleixner , x86@kernel.org, "paulmck@linux.vnet.ibm.com" Subject: Re: [PATCH] cpufreq: prevent 'policy->cpus' become offline in __gov_queue_work() Date: Wed, 05 Jun 2013 14:37:50 +0200 Message-ID: <1862476.P5VBB45STK@vostro.rjw.lan> User-Agent: KMail/4.9.5 (Linux/3.10.0-rc4+; KDE/4.9.5; x86_64; ; ) In-Reply-To: <51AEFDC4.8070801@linux.vnet.ibm.com> References: <51AEFBA1.302@linux.vnet.ibm.com> <51AEFDC4.8070801@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1372 Lines: 42 On Wednesday, June 05, 2013 04:58:44 PM Michael Wang wrote: > Hi, Viresh > > On 06/05/2013 04:53 PM, Viresh Kumar wrote: > [snip] > >> It was caused by the policy->cpus changed during the process of > >> __gov_queue_work(), in other word, cpu offline happened. > >> > >> This patch will use get/put_online_cpus() to prevent the offline > >> happen inside __gov_queue_work(), after applied the patch, the > >> warning is gone as Jiri tested: > >> > >> Link: https://lkml.org/lkml/2013/6/5/88 > >> > >> CC: "Rafael J. Wysocki" > >> CC: Viresh Kumar > >> Reported-by: Borislav Petkov > >> Reported-by: Jiri Kosina > >> Tested-by: Jiri Kosina > >> Signed-off-by: Michael Wang > >> --- > >> drivers/cpufreq/cpufreq_governor.c | 3 +++ > >> 1 files changed, 3 insertions(+), 0 deletions(-) > > > > Acked-by: Viresh Kumar > > Thanks for your ack :) Queued up for 3.10. Thanks, Rafael -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/