Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755359Ab3FENE5 (ORCPT ); Wed, 5 Jun 2013 09:04:57 -0400 Received: from smtp02.citrix.com ([66.165.176.63]:9747 "EHLO SMTP02.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753571Ab3FENEz (ORCPT ); Wed, 5 Jun 2013 09:04:55 -0400 X-IronPort-AV: E=Sophos;i="4.87,806,1363132800"; d="scan'208";a="27986101" Date: Wed, 5 Jun 2013 14:04:50 +0100 From: Stefano Stabellini X-X-Sender: sstabellini@kaball.uk.xensource.com To: Arnd Bergmann CC: , Stefano Stabellini , , , , , , , Russell King - ARM Linux Subject: Re: [PATCH v3 5/6] arm64/xen: introduce CONFIG_XEN and hypercall.S on ARM64 In-Reply-To: <1471793.18ZhhAHKN9@wuerfel> Message-ID: References: <1370434530-22428-5-git-send-email-stefano.stabellini@eu.citrix.com> <1471793.18ZhhAHKN9@wuerfel> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1793 Lines: 46 On Wed, 5 Jun 2013, Arnd Bergmann wrote: > On Wednesday 05 June 2013 13:15:29 Stefano Stabellini wrote: > > diff --git a/arch/arm64/Makefile b/arch/arm64/Makefile > > index c95c5cb..79dd13d 100644 > > --- a/arch/arm64/Makefile > > +++ b/arch/arm64/Makefile > > @@ -37,6 +37,7 @@ TEXT_OFFSET := 0x00080000 > > export TEXT_OFFSET GZFLAGS > > > > core-y += arch/arm64/kernel/ arch/arm64/mm/ > > +core-$(CONFIG_XEN) += arch/arm64/xen/ > > libs-y := arch/arm64/lib/ $(libs-y) > > libs-y += $(LIBGCC) > > > > diff --git a/arch/arm64/xen/Makefile b/arch/arm64/xen/Makefile > > new file mode 100644 > > index 0000000..be24040 > > --- /dev/null > > +++ b/arch/arm64/xen/Makefile > > @@ -0,0 +1,2 @@ > > +xen-arm-y += $(addprefix ../../arm/xen/, enlighten.o grant-table.o) > > +obj-y := xen-arm.o hypercall.o > > I think it would be nicer to redirect the entire directory, not just > the enlighten.o and grant-table.o files. You could do in arch/arm64/Makefile: > > core-(CONFIG_XEN) += arch/arm/xen/ > > That leaves a small difference in hypercall.o, which I think you can > handle with an #ifdef. That is nicer. The implementation of hypercall.S is significantly different between arm32 and arm64, so hypercall.S is going to be harder to read. However hypercall.S is just one file and it's not going to grow much, while we might have many more C source files in common between the two architecures, so I think that your approach is going to be cleaner in the long term. I'll make the change. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/