Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755678Ab3FEO4p (ORCPT ); Wed, 5 Jun 2013 10:56:45 -0400 Received: from mga14.intel.com ([143.182.124.37]:46488 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752871Ab3FEO4o (ORCPT ); Wed, 5 Jun 2013 10:56:44 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.87,807,1363158000"; d="scan'208";a="312675359" Message-ID: <51AF5193.1060209@linux.intel.com> Date: Wed, 05 Jun 2013 17:56:19 +0300 From: Eliezer Tamir User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130509 Thunderbird/17.0.6 MIME-Version: 1.0 To: Eric Dumazet CC: David Miller , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Jesse Brandeburg , Don Skidmore , e1000-devel@lists.sourceforge.net, Willem de Bruijn , Ben Hutchings , Andi Kleen , HPA , Eilon Greenstien , Or Gerlitz , Amir Vadai , Eliezer Tamir Subject: Re: [PATCH v9 net-next 5/7] net: simple poll/select low latency socket poll References: <20130605103400.11172.49099.stgit@ladj378.jer.intel.com> <20130605103452.11172.31453.stgit@ladj378.jer.intel.com> <1370439054.24311.248.camel@edumazet-glaptop> <51AF401C.2030506@linux.intel.com> <1370440607.24311.251.camel@edumazet-glaptop> <1370441849.24311.256.camel@edumazet-glaptop> In-Reply-To: <1370441849.24311.256.camel@edumazet-glaptop> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1274 Lines: 35 On 05/06/2013 17:17, Eric Dumazet wrote: > On Wed, 2013-06-05 at 06:56 -0700, Eric Dumazet wrote: > >> This looks quite easy, by adding in include/uapi/asm-generic/poll.h >> >> #define POLL_LL 0x8000 >> >> And do the sk_poll_ll() call only if flag is set. >> >> I do not think we have to support select(), as its legacy interface, and >> people wanting ll should really use epoll() or poll(). > > Alternatively, add a per socket flag to enable/disable ll > > This global enable assumes the application owns the host anyway. > I plan on adding a socket option in the next stage. I'm also testing a patch much like you described with a poll flag. Select/poll set it to indicate that they want to busy poll. Sock_poll sets it to indicate that this socket can (at the moment) busy-poll. If you think the way things are done right now is unacceptable, even as an experimental feature, I would much prefer to drop this patch and have the rest applied rather then bring in new code that is not fully tested at this stage. -Eliezer -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/