Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755969Ab3FEPJn (ORCPT ); Wed, 5 Jun 2013 11:09:43 -0400 Received: from mail-pb0-f44.google.com ([209.85.160.44]:48248 "EHLO mail-pb0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754162Ab3FEPJm (ORCPT ); Wed, 5 Jun 2013 11:09:42 -0400 Message-ID: <51AF54AE.2000606@gmail.com> Date: Wed, 05 Jun 2013 23:09:34 +0800 From: Jiang Liu User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130404 Thunderbird/17.0.5 MIME-Version: 1.0 To: Minchan Kim CC: Greg Kroah-Hartman , Nitin Gupta , Jerome Marchand , Yijing Wang , Jiang Liu , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 01/10] zram: kill unused zram_get_num_devices() References: <1370361968-8764-1-git-send-email-jiang.liu@huawei.com> <20130605055242.GA8732@blaptop> In-Reply-To: <20130605055242.GA8732@blaptop> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2666 Lines: 83 On Wed 05 Jun 2013 01:52:42 PM CST, Minchan Kim wrote: > Hello, > > On Wed, Jun 05, 2013 at 12:05:59AM +0800, Jiang Liu wrote: >> Now there's no caller of zram_get_num_devices(), so kill it. >> And change zram_devices to static because it's only used in zram_drv.c. >> >> Signed-off-by: Jiang Liu > > I am looking at next-20130604 and am still seeing that dev_to_zram is using it. > Maybe I expect Greg picked your eariler patch yesterday but I didn't Cced and > your patchset doesn't say anything about that although your patchset's title > says it's v2. So I'd like to make it clear. Hi Minchan, The first patch of the patchset should be "zram: simplify and optimize dev_to_zram()" but I missed that one in v2. Sorry for the inconvenience. Will resend v3 with the first patch. Regards! Gerry > > Thanks. > >> --- >> drivers/staging/zram/zram_drv.c | 7 +------ >> drivers/staging/zram/zram_drv.h | 2 -- >> 2 files changed, 1 insertion(+), 8 deletions(-) >> >> diff --git a/drivers/staging/zram/zram_drv.c b/drivers/staging/zram/zram_drv.c >> index e34e3fe..0a07de4 100644 >> --- a/drivers/staging/zram/zram_drv.c >> +++ b/drivers/staging/zram/zram_drv.c >> @@ -37,7 +37,7 @@ >> >> /* Globals */ >> static int zram_major; >> -struct zram *zram_devices; >> +static struct zram *zram_devices; >> >> /* Module params (documentation at end) */ >> static unsigned int num_devices = 1; >> @@ -669,11 +669,6 @@ static void destroy_device(struct zram *zram) >> blk_cleanup_queue(zram->queue); >> } >> >> -unsigned int zram_get_num_devices(void) >> -{ >> - return num_devices; >> -} >> - >> static int __init zram_init(void) >> { >> int ret, dev_id; >> diff --git a/drivers/staging/zram/zram_drv.h b/drivers/staging/zram/zram_drv.h >> index 2d1a3f1..a18b66d 100644 >> --- a/drivers/staging/zram/zram_drv.h >> +++ b/drivers/staging/zram/zram_drv.h >> @@ -109,8 +109,6 @@ struct zram { >> struct zram_stats stats; >> }; >> >> -extern struct zram *zram_devices; >> -unsigned int zram_get_num_devices(void); >> #ifdef CONFIG_SYSFS >> extern struct attribute_group zram_disk_attr_group; >> #endif >> -- >> 1.8.1.2 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> Please read the FAQ at http://www.tux.org/lkml/ > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/