Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756557Ab3FEPbM (ORCPT ); Wed, 5 Jun 2013 11:31:12 -0400 Received: from mga02.intel.com ([134.134.136.20]:50711 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756479Ab3FEPbI (ORCPT ); Wed, 5 Jun 2013 11:31:08 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.87,807,1363158000"; d="scan'208";a="324693352" Message-ID: <51AF59B0.6080101@linux.intel.com> Date: Wed, 05 Jun 2013 18:30:56 +0300 From: Eliezer Tamir User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130509 Thunderbird/17.0.6 MIME-Version: 1.0 To: Eric Dumazet CC: David Miller , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Jesse Brandeburg , Don Skidmore , e1000-devel@lists.sourceforge.net, Willem de Bruijn , Ben Hutchings , Andi Kleen , HPA , Eilon Greenstien , Or Gerlitz , Amir Vadai , Eliezer Tamir Subject: Re: [PATCH v9 net-next 2/7] net: add low latency socket poll References: <20130605103400.11172.49099.stgit@ladj378.jer.intel.com> <20130605103421.11172.82925.stgit@ladj378.jer.intel.com> <1370445714.24311.268.camel@edumazet-glaptop> In-Reply-To: <1370445714.24311.268.camel@edumazet-glaptop> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 887 Lines: 24 On 05/06/2013 18:21, Eric Dumazet wrote: > On Wed, 2013-06-05 at 13:34 +0300, Eliezer Tamir wrote: > > > This is probably too big to be inlined, and nonblock should be a bool > It would also make sense to give end_time as a parameter, so that the > polling() code could really give a end_time for the whole duration of > poll(). > > (You then should test can_poll_ll(end_time) _before_ call to > ndo_ll_poll()) how would you handle a nonblocking operation in that case? I guess if we have a socket option, then we don't need to handle none blocking any diffrent, since the user specified exactly how much time to waste polling. right? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/