Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756838Ab3FERS4 (ORCPT ); Wed, 5 Jun 2013 13:18:56 -0400 Received: from avon.wwwdotorg.org ([70.85.31.133]:50685 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756190Ab3FERSz (ORCPT ); Wed, 5 Jun 2013 13:18:55 -0400 Message-ID: <51AF72F9.3060307@wwwdotorg.org> Date: Wed, 05 Jun 2013 11:18:49 -0600 From: Stephen Warren User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 MIME-Version: 1.0 To: Linus Walleij CC: =?ISO-8859-1?Q?Heiko_St=FCbner?= , Laurent Pinchart , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , John Stultz , Thomas Gleixner , Mike Turquette , Seungwon Jeon , Jaehoon Chung , Chris Ball , "linux-mmc@vger.kernel.org" , Grant Likely , Rob Herring , "devicetree-discuss@lists.ozlabs.org" , Russell King , Arnd Bergmann , Olof Johansson Subject: Re: [PATCH 07/10] pinctrl: add pinctrl driver for Rockchip SoCs References: <201306030055.15413.heiko@sntech.de> <201306030059.47611.heiko@sntech.de> <201306041405.13320.heiko@sntech.de> In-Reply-To: X-Enigmail-Version: 1.4.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1174 Lines: 24 On 06/05/2013 01:01 AM, Linus Walleij wrote: > On Tue, Jun 4, 2013 at 2:05 PM, Heiko St?bner wrote: ... >> The only problem is the pull stuff mentioned above that is either pull up or >> down without the driver having knowledge about it. And generic_pinconf only >> knows about them separately right now. > > Create a separate patch adding PIN_CONFIG_BIAS_PULL_AUTO > to include/linux/pinctrl/pinconf-generic.h, don't forget the > kerneldoc, and patching drivers/pinctrl/pinconf-generic.c. "AUTO" sounds really rather generic. Based on just the word "AUTO", I have no idea if it's a HW- or SW-supplied default, or what the algorithm is for determining the automatically selected value. Perhaps s/AUTO/PIN_DEFAULT/ or something like that? While the concept is simple enough, it's unusual enough that such a patch would hopefully have a comment containing a full explanation of exactly what this option means. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/