Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756834Ab3FESpJ (ORCPT ); Wed, 5 Jun 2013 14:45:09 -0400 Received: from kdh-gw.itdev.co.uk ([89.21.227.133]:12608 "EHLO hermes.kdh.itdev.co.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756366Ab3FESpI (ORCPT ); Wed, 5 Jun 2013 14:45:08 -0400 Message-ID: <51AF8730.4010507@itdev.co.uk> Date: Wed, 05 Jun 2013 19:45:04 +0100 From: Nick Dyer User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 MIME-Version: 1.0 To: Dmitry Torokhov CC: Daniel Kurtz , Henrik Rydberg , Joonyoung Shim , Alan.Bowens@atmel.com, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, pmeerw@pmeerw.net, bleung@chromium.org, olofj@chromium.org Subject: Re: [PATCH 10/53] Input: atmel_mxt_ts - Add memory access interface via sysfs References: <1370453866-16534-1-git-send-email-nick.dyer@itdev.co.uk> <1370453866-16534-11-git-send-email-nick.dyer@itdev.co.uk> <7380889.l4hHqCT0mm@dtor-d630.eng.vmware.com> In-Reply-To: <7380889.l4hHqCT0mm@dtor-d630.eng.vmware.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1156 Lines: 23 Dmitry Torokhov wrote: > On Wednesday, June 05, 2013 06:37:03 PM Nick Dyer wrote: >> Atmel maXTouch chips can be addressed via an "Object Based Protocol" which >> defines how i2c registers are mapped to different functions within the >> chips. This interface exposes the register map and allows user-space >> utilities to inspect and alter object configuration, and to view diagnostic >> data, while the device is running. > > I think if the driver was to use regmap then this fucntionality will already > be there as regmap exports registers via debugfs. Yes, this was suggested in the past and I spent some time looking into it. We have made a deliberate choice to implement this via sysfs rather than debugfs since it needs to work on devices that don't have debugfs enabled. In addition, there are some quirks about the way in which we have to read/write registers which means regmap isn't a good fit. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/