Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757504Ab3FEUUN (ORCPT ); Wed, 5 Jun 2013 16:20:13 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:56553 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756628Ab3FEUUM (ORCPT ); Wed, 5 Jun 2013 16:20:12 -0400 Message-ID: <51AF9D77.2000901@canonical.com> Date: Wed, 05 Jun 2013 15:20:07 -0500 From: Dave Chiluk User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 MIME-Version: 1.0 To: Petr Vandrovec CC: linux-kernel@vger.kernel.org, Al Viro Subject: Re: [PATCH] ncpfs: fix rmdir returns Device or resource busy References: <1369781410-24473-1-git-send-email-chiluk@canonical.com> <51A918B8.20303@canonical.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2579 Lines: 73 Petr do you still have commit rights to ncpfs? Can you please commit it to upstream or do I have to get Al to do that? Dave. On 05/31/2013 05:22 PM, Petr Vandrovec wrote: > Looks OK to me. > > As I said elsewhere, I do not use ncpfs for years so I cannot provide > any sensible maintainership for it anymore :-( > > Petr > > On May 31, 2013 2:40 PM, "Dave Chiluk" > wrote: > > Any thoughts on this? NCPFS seems to be the forgotten, left-behind, > red-headed stepchild of the fs community. > > Dave. > > On 05/28/2013 05:50 PM, Dave Chiluk wrote: > > 1d2ef5901483004d74947bbf78d5146c24038fe7 caused a regression in > ncpfs such that > > directories could no longer be removed. This was because > ncp_rmdir checked > > to see if a dentry could be unhashed before allowing it to be > removed. Since > > 1d2ef5901483004d74947bbf78d5146c24038fe7 introduced a change that > incremented > > dentry->d_count causing it to always be greater than 1 unhash > would always > > fail. Thus causing the error path in ncp_rmdir to always be > taken. Removing > > this error path is safe as unhashing is still accomplished by > calls to dput > > from vfs_rmdir. > > --- > > fs/ncpfs/dir.c | 9 --------- > > 1 file changed, 9 deletions(-) > > > > diff --git a/fs/ncpfs/dir.c b/fs/ncpfs/dir.c > > index 8163260..6792ce1 100644 > > --- a/fs/ncpfs/dir.c > > +++ b/fs/ncpfs/dir.c > > @@ -1029,15 +1029,6 @@ static int ncp_rmdir(struct inode *dir, > struct dentry *dentry) > > DPRINTK("ncp_rmdir: removing %s/%s\n", > > dentry->d_parent->d_name.name , > dentry->d_name.name ); > > > > - /* > > - * fail with EBUSY if there are still references to this > > - * directory. > > - */ > > - dentry_unhash(dentry); > > - error = -EBUSY; > > - if (!d_unhashed(dentry)) > > - goto out; > > - > > len = sizeof(__name); > > error = ncp_io2vol(server, __name, &len, dentry->d_name.name > , > > dentry->d_name.len, !ncp_preserve_case(dir)); > > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/