Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932152Ab3FEUbJ (ORCPT ); Wed, 5 Jun 2013 16:31:09 -0400 Received: from hydra.sisk.pl ([212.160.235.94]:58460 "EHLO hydra.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932065Ab3FEUbH (ORCPT ); Wed, 5 Jun 2013 16:31:07 -0400 From: "Rafael J. Wysocki" To: Joe Jin Cc: Viresh Kumar , Neil Gu , cpufreq@vger.kernel.org, linux-pm@vger.kernel.org, "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] ACPI: update user_policy.max when _PPC updated Date: Wed, 05 Jun 2013 22:40:11 +0200 Message-ID: <31897041.QcNuTieHbo@vostro.rjw.lan> User-Agent: KMail/4.9.5 (Linux/3.10.0-rc4+; KDE/4.9.5; x86_64; ; ) In-Reply-To: <51AE8BE4.8050409@oracle.com> References: <51AE8BE4.8050409@oracle.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2048 Lines: 62 On Wednesday, June 05, 2013 08:52:52 AM Joe Jin wrote: > When _PPC changed dynamically the user_policy.max will not be updated, > this prevent CPU run on the highest frequency. Why should the user setting be always related to the current maximum available frequency? What if the user sets the limit for power capping purposes? Rafael > Signed-off-by: Joe Jin > Cc: Rafael J. Wysocki > Cc: Viresh Kumar > --- > drivers/acpi/processor_perflib.c | 17 ++++++++++++++++- > 1 file changed, 16 insertions(+), 1 deletion(-) > > diff --git a/drivers/acpi/processor_perflib.c b/drivers/acpi/processor_perflib.c > index e854582..e01aa7d 100644 > --- a/drivers/acpi/processor_perflib.c > +++ b/drivers/acpi/processor_perflib.c > @@ -180,6 +180,7 @@ static void acpi_processor_ppc_ost(acpi_handle handle, int status) > int acpi_processor_ppc_has_changed(struct acpi_processor *pr, int event_flag) > { > int ret; > + unsigned int saved = (unsigned int)pr->performance_platform_limit; > > if (ignore_ppc) { > /* > @@ -204,8 +205,22 @@ int acpi_processor_ppc_has_changed(struct acpi_processor *pr, int event_flag) > } > if (ret < 0) > return (ret); > - else > + else { > + unsigned int ppc = (unsigned int)pr->performance_platform_limit; > + > + if (saved != ppc) { > + struct cpufreq_policy *policy; > + > + policy = cpufreq_cpu_get(pr->id); > + if (likely(policy)) > + policy->user_policy.max = > + pr->performance->states[ppc]. > + core_frequency * 1000; > + cpufreq_cpu_put(policy); > + } > + > return cpufreq_update_policy(pr->id); > + } > } > > int acpi_processor_get_bios_limit(int cpu, unsigned int *limit) > -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/