Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755933Ab3FFBXc (ORCPT ); Wed, 5 Jun 2013 21:23:32 -0400 Received: from mail-pa0-f51.google.com ([209.85.220.51]:61393 "EHLO mail-pa0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755559Ab3FFBXa (ORCPT ); Wed, 5 Jun 2013 21:23:30 -0400 Date: Thu, 6 Jun 2013 09:23:13 +0800 From: Wang YanQing To: Pavel Machek Cc: gregkh@linuxfoundation.org, sfr@canb.auug.org.au, linux-next@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] TTY:vt: convert remain take_over_console's users to do_take_over_console Message-ID: <20130606012312.GA2001@udknight> Mail-Followup-To: Wang YanQing , Pavel Machek , gregkh@linuxfoundation.org, sfr@canb.auug.org.au, linux-next@vger.kernel.org, linux-kernel@vger.kernel.org References: <20130521051511.GA11435@udknight> <20130604201317.GA16303@amd.pavel.ucw.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130604201317.GA16303@amd.pavel.ucw.cz> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1259 Lines: 35 On Tue, Jun 04, 2013 at 10:13:18PM +0200, Pavel Machek wrote: > On Tue 2013-05-21 13:15:12, Wang YanQing wrote: > > Impact: > > 1:convert all remain take_over_console to do_take_over_console > > This is step backwards. What is step backwards? do_take_over_console appear MUCH MUCH later in kernel than take_over_console, do_take_over_console is the new API, I can't understand what is step backwards. > > --- a/arch/alpha/kernel/console.c > > +++ b/arch/alpha/kernel/console.c > > @@ -61,7 +61,9 @@ locate_and_init_vga(void *(*sel_func)(void *, void *)) > > > > /* Set the VGA hose and init the new console. */ > > pci_vga_hose = hose; > > - take_over_console(&vga_con, 0, MAX_NR_CONSOLES-1, 1); > > + console_lock(); > > + do_take_over_console(&vga_con, 0, MAX_NR_CONSOLES-1, 1); > > + console_unlock(); > > } > > Original was better. Except reduce some console_lock/unlock scatter scattered in kernel, I can't see the "BETTER", and it is not a BIG problem for the benefit to unify the API. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/