Return-Path: <linux-kernel-owner+willy=40w.ods.org@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id <S262770AbSJCDrz>; Wed, 2 Oct 2002 23:47:55 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org
	id <S262769AbSJCDrz>; Wed, 2 Oct 2002 23:47:55 -0400
Received: from dino.conectiva.com.br ([200.250.58.152]:15377 "EHLO
	dino.conectiva.com.br") by vger.kernel.org with ESMTP
	id <S262768AbSJCDry>; Wed, 2 Oct 2002 23:47:54 -0400
To: YOSHIFUJI@conectiva.com.br, UNEXPECTED_DATA_AFTER_ADDRESS@.SYNTAX-ERROR
Subject: Re: [PATCH] IPv6: Allow Both IPv6 and IPv4 Sockets on the Same Port Number (IPV6_V6ONLY Support)
Message-ID: <1033617195.3d9bbf2b900e4@webmail.conectiva.com.br>
Date: Thu, 03 Oct 2002 00:53:15 -0300 (BRST)
From: acme@conectiva.com.br
Cc: linux-kernel@vger.kernel.org, netdev@oss.sgi.com, usagi@linux-ipv6.org
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7BIT
User-Agent: IMP/PHP IMAP webmail program 2.2.8
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 744
Lines: 19


Quoting YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@linux-ipv6.org>: 
 
> +#define IN6_IS_ADDR_V4MAPPED(a)				\ 
> +	((((a)->s6_addr32[0]) == 0) &&			\ 
> +	 (((a)->s6_addr32[1]) == 0) &&			\ 
> +	 (((a)->s6_addr32[2]) == __constant_htonl(0x0000ffff))) 
 
Please use plain htonl, __constant_htonl is only needed in static 
initializations, in all other cases with constants as a parameter it 
generates the same code as htonl, so lets prefer using the shorter, 
more readable format. 
 
- Arnaldo 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/