Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757356Ab3FFIF2 (ORCPT ); Thu, 6 Jun 2013 04:05:28 -0400 Received: from 11.mo1.mail-out.ovh.net ([188.165.48.29]:49375 "EHLO mo1.mail-out.ovh.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756827Ab3FFIFX convert rfc822-to-8bit (ORCPT ); Thu, 6 Jun 2013 04:05:23 -0400 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 6.3 \(1503\)) X-Ovh-Mailout: 178.32.228.1 (mo1.mail-out.ovh.net) Subject: Re: [PATCH] simplefb: add support for a8b8g8r8 pixel format From: Jean-Christophe PLAGNIOL-VILLARD In-Reply-To: <1370503259-16618-1-git-send-email-acourbot@nvidia.com> Date: Thu, 6 Jun 2013 09:59:48 +0200 Cc: Jean-Christophe PLAGNIOL-VILLARD , Tomi Valkeinen , Stephen Warren , Olof Johansson , , , Content-Transfer-Encoding: 8BIT Message-Id: <3356BC4D-EEF6-4FCA-9310-5B0727EBF288@jcrosoft.com> References: <1370503259-16618-1-git-send-email-acourbot@nvidia.com> To: Alexandre Courbot X-Mailer: Apple Mail (2.1503) X-Ovh-Tracer-Id: 4718646511133305832 X-Ovh-Remote: 90.37.12.95 (amarseille-152-1-106-95.w90-37.abo.wanadoo.fr) X-Ovh-Local: 213.186.33.20 (ns0.ovh.net) X-OVH-SPAMSTATE: OK X-OVH-SPAMSCORE: -100 X-OVH-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrfeeiiedrfeeiucetufdoteggodetrfcurfhrohhfihhlvgemucfqggfjnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd X-Spam-Check: DONE|U 0.5/N X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrfeeiiedrfeeiucetufdoteggodetrfcurfhrohhfihhlvgemucfqggfjnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1736 Lines: 49 On Jun 6, 2013, at 9:20 AM, Alexandre Courbot wrote: > Signed-off-by: Alexandre Courbot > --- > Documentation/devicetree/bindings/video/simple-framebuffer.txt | 1 + > drivers/video/simplefb.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/video/simple-framebuffer.txt b/Documentation/devicetree/bindings/video/simple-framebuffer.txt > index 3ea4605..70c26f3 100644 > --- a/Documentation/devicetree/bindings/video/simple-framebuffer.txt > +++ b/Documentation/devicetree/bindings/video/simple-framebuffer.txt > @@ -12,6 +12,7 @@ Required properties: > - stride: The number of bytes in each line of the framebuffer. > - format: The format of the framebuffer surface. Valid values are: > - r5g6b5 (16-bit pixels, d[15:11]=r, d[10:5]=g, d[4:0]=b). > + - a8b8g8r8 (32-bit pixels, d[31:24]=a, d[23:16]=b, d[15:8]=g, d[7:0]=r). > > Example: > > diff --git a/drivers/video/simplefb.c b/drivers/video/simplefb.c > index e2e9e3e..d7041aa 100644 > --- a/drivers/video/simplefb.c > +++ b/drivers/video/simplefb.c > @@ -84,6 +84,7 @@ struct simplefb_format { > > static struct simplefb_format simplefb_formats[] = { > { "r5g6b5", 16, {11, 5}, {5, 6}, {0, 5}, {0, 0} }, > + { "a8b8g8r8", 32, {0, 8}, {8, 8}, {16, 8}, {31, 8} }, why don't you parse the string? so you will a real generic bindings Best Regards, J. > }; > > struct simplefb_params { > -- > 1.8.3 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/