Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755801Ab3FFJDo (ORCPT ); Thu, 6 Jun 2013 05:03:44 -0400 Received: from smtp.eu.citrix.com ([46.33.159.39]:10654 "EHLO SMTP.EU.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932329Ab3FFJDm (ORCPT ); Thu, 6 Jun 2013 05:03:42 -0400 X-IronPort-AV: E=Sophos;i="4.87,814,1363132800"; d="scan'208";a="5384016" Message-ID: <1370509419.24512.224.camel@zakaz.uk.xensource.com> Subject: Re: [Xen-devel] [PATCH v4 5/6] arm64/xen: introduce CONFIG_XEN on ARM64 From: Ian Campbell To: Stefano Stabellini CC: , , , , , Date: Thu, 6 Jun 2013 10:03:39 +0100 In-Reply-To: <1370451727-26826-5-git-send-email-stefano.stabellini@eu.citrix.com> References: <1370451727-26826-5-git-send-email-stefano.stabellini@eu.citrix.com> Organization: Citrix Systems, Inc. Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.4.4-1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.30.203.1] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1233 Lines: 34 On Wed, 2013-06-05 at 18:02 +0100, Stefano Stabellini wrote: > Changes in v4: > - build the entire arch/arm/xen directory under arch/arm64, ifdef > hypercall.S appropriately. This is probably the best (or equal first) of a bunch of bad options :-/ > + * The Xen hypercall calling convention is very similar to the ARM/ARM64 > + * procedure calling convention: the first paramter is passed in r0/x0, "parameter" > + * the second in r1/x1, the third in r2/x2 and the fourth in r3/x3. > + * Considering that Xen hypercalls have 5 arguments at most, the fifth > + * paramter is always passed in r4/x4, differently from the ARM > + * procedure calling convention of using the stack for that case. and "parameter" again. Strictly speaking the fifth argument handling only differs from the 32-bit PCS, not the 64-bit one. Splitting hairs a bit there. If you fix the typo and clarify the fifth argument or not as you wish: Acked-by: Ian Campbell Ian. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/