Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933277Ab3FFNFD (ORCPT ); Thu, 6 Jun 2013 09:05:03 -0400 Received: from mail-pd0-f173.google.com ([209.85.192.173]:57223 "EHLO mail-pd0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932940Ab3FFNFB (ORCPT ); Thu, 6 Jun 2013 09:05:01 -0400 MIME-Version: 1.0 In-Reply-To: <51B03FB0.80306@cn.fujitsu.com> References: <1370071212-7715-1-git-send-email-linkinjeon@gmail.com> <51AD698F.3020305@cn.fujitsu.com> <51B03FB0.80306@cn.fujitsu.com> Date: Thu, 6 Jun 2013 22:05:00 +0900 Message-ID: Subject: Re: [PATCH 1/2] f2fs: add remount_fs callback support From: Namjae Jeon To: Gu Zheng Cc: jaegeuk.kim@samsung.com, linux-f2fs-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Namjae Jeon , Pankaj Kumar Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1109 Lines: 36 [snip] >> >>> >>>> + >>>> + /** >>>> + * We stop the GC thread if FS is mounted as RO >>>> + * or if background_gc = 0 is passed in mount >>>> + * option. Also sync the filesystem. >>>> + */ >>>> + if ((*flags & MS_RDONLY) || !test_opt(sbi, BG_GC)) { >>> >>> >>> Another condition: The old mount is not RO. >> I don't think that it is needed. I think current condition check can >> be covered about all cases. >> Am I missing something ? > Hi Gu. > Maybe. If the old mount is RO, so does the remount. It still can pass the judgement here, right? > Though the following stop_gc_thread() and f2fs_sync_fs() can handle this case well, but this > is unnecessary and needless. If we add additional judgement of whether old mount is not RO can avoid this. > Okay, I understand. I will update it on v2 patch. Thanks~. > Thanks, > Gu > >> >>> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/