Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751990Ab3FFNpl (ORCPT ); Thu, 6 Jun 2013 09:45:41 -0400 Received: from mail-pa0-f44.google.com ([209.85.220.44]:60635 "EHLO mail-pa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750971Ab3FFNpj (ORCPT ); Thu, 6 Jun 2013 09:45:39 -0400 Message-ID: <1370526337.24311.335.camel@edumazet-glaptop> Subject: Re: [PATCH] net: Unbreak compat_sys_{send,recv}msg From: Eric Dumazet To: David Miller Cc: luto@amacapital.net, x86@kernel.org, torvalds@linux-foundation.org, mikey@neuling.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org, trinity@vger.kernel.org Date: Thu, 06 Jun 2013 06:45:37 -0700 In-Reply-To: <20130606.002625.223430401087826901.davem@davemloft.net> References: <20130606132926.f4161ddff87dc9a55e33a8ca@canb.auug.org.au> <20130606.002625.223430401087826901.davem@davemloft.net> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1691 Lines: 48 On Thu, 2013-06-06 at 00:26 -0700, David Miller wrote: > From: Andy Lutomirski > Date: Wed, 5 Jun 2013 22:38:26 -0700 > > > I broke them in this commit: > > > > commit 1be374a0518a288147c6a7398792583200a67261 > > Author: Andy Lutomirski > > Date: Wed May 22 14:07:44 2013 -0700 > > > > net: Block MSG_CMSG_COMPAT in send(m)msg and recv(m)msg > > > > This patch adds __sys_sendmsg and __sys_sendmsg as common helpers that accept > > MSG_CMSG_COMPAT and blocks MSG_CMSG_COMPAT at the syscall entrypoints. It > > also reverts some unnecessary checks in sys_socketcall. > > > > Apparently I was suffering from underscore blindness the first time around. > > > > Signed-off-by: Andy Lutomirski > > Eric, can you test this patch too? Yes, this fixes the problem as well on x86_64 Tested-by: Eric Dumazet Thanks ! PS: I had following fuzz while applying on Linus tree : patching file include/linux/socket.h Hunk #1 succeeded at 320 (offset -1 lines). patching file net/compat.c patching file net/socket.c Hunk #1 succeeded at 1956 (offset -22 lines). Hunk #2 succeeded at 2071 (offset -22 lines). Hunk #3 succeeded at 2125 (offset -22 lines). Hunk #4 succeeded at 2163 (offset -22 lines). Hunk #5 succeeded at 2255 (offset -22 lines). Hunk #6 succeeded at 2317 (offset -22 lines). Hunk #7 succeeded at 2515 (offset -20 lines). -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/