Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752667Ab3FFPa6 (ORCPT ); Thu, 6 Jun 2013 11:30:58 -0400 Received: from mail.abilis.ch ([195.70.19.74]:17982 "EHLO mail.abilis.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752175Ab3FFPaz convert rfc822-to-8bit (ORCPT ); Thu, 6 Jun 2013 11:30:55 -0400 Date: Thu, 6 Jun 2013 17:30:31 +0200 From: Christian Ruppert To: Haojian Zhuang Cc: Linus Walleij , Stephen Warren , Shiraz HASHIM , Patrice CHOTARD , "linux-kernel@vger.kernel.org" , Grant Likely , Rob Herring , Rob Landley , Sascha Leuenberger , Pierrick Hascoet , "devicetree-discuss@lists.ozlabs.org" , "linux-doc@vger.kernel.org" Subject: Re: [PATCH 1/2] pinmux: Add TB10x pinmux driver Message-ID: <20130606153030.GA19876@ab42.lan> References: <51942472.9010402@wwwdotorg.org> <20130522142824.GC4789@ab42.lan> <20130524115053.GB5203@ab42.lan> <20130603123001.GD31808@ab42.lan> <20130606141115.GA10345@ab42.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: User-Agent: Mutt/1.5.20 (2009-12-10) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3611 Lines: 93 On Thu, Jun 06, 2013 at 10:32:21PM +0800, Haojian Zhuang wrote: > On 6 June 2013 22:11, Christian Ruppert wrote: > > On Wed, Jun 05, 2013 at 09:44:27AM +0800, Haojian Zhuang wrote: > >> On 3 June 2013 20:30, Christian Ruppert wrote: > >> > OK, here's a simplified example of what we would like to do (this seems > >> > pretty common so I suppose there is a way I haven't understood). Our > >> > situation is slightly more complex but for the purpose of discussion > >> > let's assume a chip with 8 pins which can be configured for the > >> > following functions: > >> > > >> > Pin GPIO-A I2C SPI0 SPI1 > >> > ------------------------------------ > >> > 1 GPIOA0 SDA MISO1 > >> > 2 GPIOA1 SCL MOSI1 > >> > 3 GPIOA2 SS1_B > >> > 4 GPIOA3 SCLK1 > >> > 5 GPIOA4 MISO0 > >> > 6 GPIOA5 MOSI0 > >> > 7 GPIOA6 SS0_B > >> > 8 GPIOA7 SCLK0 > >> > > >> > We can now define the following pinctrl-single: > >> > > >> > pinmux: pinmux@0xFFEE0000 { > >> > compatible = "pinctrl-single"; > >> > reg = <0xFFEE0000 0x8>; > >> > #address-cells = <1>; > >> > #size-cells = <0>; > >> > #gpio-range-cells = <3>; > >> > pinctrl-single,register-width = <32>; > >> > pinctrl-single,function-mask = <0xffffffff>; > >> > pinctrl-single,gpio-range = <&range 1 8 0>; > >> > gpioa_pins: pinmux_gpioa_pins { > >> > pinctrl-single,pins = <0x0 0 0x4 0> > >> > }; > >> > i2c_pins: pinmux_i2c_pins { > >> > pinctrl-single,pins = <0x0 1> > >> > }; > >> > spi0_pins: pinmux_spi0_pins { > >> > pinctrl-single,pins = <0x1 1> > >> <0x1 1>? > >> > >> If each pinmux register is only for one pin in your SoC. > >> I think that your definitions are wrong above. We use > >> register offset as the first argument, not pin number. > >> And the second argument should be pin function number. > > > > In our case each pinmux register (bit field) actually controls an entire > > group of pins. > > > >> If multiple pins are sharing one register with different bits, > >> you need to enable "pinctrl-single,bit-per-mux". > > > > Multiple pins are sharing the same bits in the same register. Do you > > think this prevents us from using pinctrl-single? > > > Could you give me your register definition? Then I can understand you > better. In our example, the register map would look a bit like the following. Note that every register configures four pins at a time. Register 0x0: Mode GPIO-A I2C SPI1 Value 0x0 0x1 0x2 --------------------------- Pin1 GPIOA0 SDA MISO1 Pin2 GPIOA1 SCL MOSI1 Pin3 GPIOA2 SS1_B Pin4 GPIOA3 SCLK1 Register 0x4: Mode GPIO-A SPI0 Value 0x0 0x1 --------------------- Pin5 GPIOA4 MISO0 Pin6 GPIOA5 MOSI0 Pin7 GPIOA6 SS0_B Pin8 GPIOA7 SCLK0 Greetings, Christian -- Christian Ruppert , /| Tel: +41/(0)22 816 19-42 //| 3, Chemin du Pr?-Fleuri _// | bilis Systems CH-1228 Plan-les-Ouates -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/