Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Thu, 3 Oct 2002 07:47:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Thu, 3 Oct 2002 07:47:19 -0400 Received: from kim.it.uu.se ([130.238.12.178]:38325 "EHLO kim.it.uu.se") by vger.kernel.org with ESMTP id ; Thu, 3 Oct 2002 07:47:19 -0400 From: Mikael Pettersson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <15772.12175.196556.383774@kim.it.uu.se> Date: Thu, 3 Oct 2002 13:52:47 +0200 To: Alexander Viro Cc: linux-kernel@vger.kernel.org Subject: Re: initrd breakage in 2.5.38-2.5.40 In-Reply-To: References: <15772.9013.244887.809979@kim.it.uu.se> X-Mailer: VM 6.90 under Emacs 20.7.1 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 911 Lines: 23 Alexander Viro writes: > > > On Thu, 3 Oct 2002, Mikael Pettersson wrote: > > > First I thought the problem was caused by a apparently missing > > set_capacity() call in 2.5.38's drivers/block/rd.c: > > I _really_ doubt it - check the loop just above the add_disk() one. > set_capacity() call is done there, repeating it won't change anything. That loop does set_capacity() on each element in rd_disks[], but set_capacity(disk,size) just sets disk->capacity = size, and initrd_disk is a different variable so I don't see how initrd_disk could ever get a capacity assigned to it unless by an explicit "set_capacity(&initrd_disk, rd_size * 2);". /Mikael - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/