Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755328Ab3FGJCh (ORCPT ); Fri, 7 Jun 2013 05:02:37 -0400 Received: from mail.free-electrons.com ([94.23.35.102]:47580 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755228Ab3FGJCa (ORCPT ); Fri, 7 Jun 2013 05:02:30 -0400 Date: Fri, 7 Jun 2013 11:02:28 +0200 From: "maxime.ripard@free-electrons.com" To: Hector Palacios Cc: FlorianSchandinat@gmx.de, linux-fbdev@vger.kernel.org, Juergen Beisert , "linux-arm-kernel@lists.infradead.org" , "fabio.estevam@freescale.com" , "brian@crystalfontz.com" , "linux-kernel@vger.kernel.org" , Alexandre Belloni , "shawn.guo@linaro.org" , plagnioj@jcrosoft.com Subject: Re: [PATCH] video: mxsfb: fix color settings for 18bit data bus and 32bpp Message-ID: <20130607090228.GI14209@lukather> References: <519E03B0.1080006@digi.com> <519F4435.5010703@digi.com> <201305241300.25461.jbe@pengutronix.de> <201305241533.19941.jbe@pengutronix.de> <20130607072103.GF14209@lukather> <51B18BA0.50506@digi.com> <20130607074200.GG14209@lukather> <51B1957F.40104@digi.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <51B1957F.40104@digi.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1385 Lines: 35 Hi Hector, On Fri, Jun 07, 2013 at 10:10:39AM +0200, Hector Palacios wrote: > For a combination of 18bit LCD data bus width and a color > mode of 32bpp, the driver was setting the color mapping to > rgb666, which is wrong, as the color in memory realy has an > rgb888 layout. > > This patch also removes the setting of flag CTRL_DF24 that > makes the driver dimiss the upper 2 bits when handling 32/24bpp > colors in a diplay with 18bit data bus width. This flag made > true color images display wrong in such configurations. > > Finally, the color mapping rgb666 has also been removed as nobody > is using it and high level applications like Qt5 cannot work > with it either. > > Reference: https://lkml.org/lkml/2013/5/23/220 > Signed-off-by: Hector Palacios > Acked-by: Juergen Beisert Acked-by: Maxime Ripard Please also note that fbdev is now maintained by Jean Christophe Plagniol-Villard (plagnioj@jcrosoft.com, in CC), and that he is away until the 10th of June, so maybe it should be safe to resend it to him after this date. Thanks! Maxime -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/