Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755370Ab3FGJUn (ORCPT ); Fri, 7 Jun 2013 05:20:43 -0400 Received: from mail-ob0-f172.google.com ([209.85.214.172]:42886 "EHLO mail-ob0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755255Ab3FGJUk (ORCPT ); Fri, 7 Jun 2013 05:20:40 -0400 MIME-Version: 1.0 In-Reply-To: <1369145282-14419-3-git-send-email-prakash.pm@ti.com> References: <1369145282-14419-1-git-send-email-prakash.pm@ti.com> <1369145282-14419-3-git-send-email-prakash.pm@ti.com> Date: Fri, 7 Jun 2013 11:20:39 +0200 Message-ID: Subject: Re: [PATCH 1/3] pinctrl: pinctrl-single: enhance to configure multiple pins of different modules From: Linus Walleij To: "Manjunathappa, Prakash" Cc: "Nori, Sekhar" , Grant Likely , Rob Herring , Russell King - ARM Linux , Rob Landley , ext Tony Lindgren , Prabhakar Lad , Peter Ujfalusi , "devicetree-discuss@lists.ozlabs.org" , "linux-doc@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "davinci-linux-open-source@linux.davincidsp.com" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1349 Lines: 34 On Tue, May 21, 2013 at 4:08 PM, Manjunathappa, Prakash wrote: > Add support to configure multiple pins in each register, existing > implementation added by [1] does not support full fledge multiple pin > configuration in single register, reports a pin clash when different > modules configure different bits of same register. The issue reported > and discussed here > http://www.spinics.net/lists/arm-kernel/msg235213.html > > With pinctrl-single,bits-per-mux property specified, use function-mask > property to find out number pins to configure. Allocate and register > pin control functions based sub mask. > > Tested on da850/omap-l138 EVM. > does not support variable submask for pins. > does not support pinconf. > > [1] "pinctrl: pinctrl-single: Add pinctrl-single,bits type of mux" > (9e605cb68a21d5704839a192a46ebcf387773704), > > Signed-off-by: Manjunathappa, Prakash > Reported-by: Lad, Prabhakar > Tested-by: Lad, Prabhakar Patch applied with Haojian's and Tony's ACK. Thanks! Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/