Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755603Ab3FGLA5 (ORCPT ); Fri, 7 Jun 2013 07:00:57 -0400 Received: from chaos.universe-factory.net ([5.9.180.86]:36819 "EHLO chaos.universe-factory.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754580Ab3FGLAz (ORCPT ); Fri, 7 Jun 2013 07:00:55 -0400 Message-ID: <51B1BD64.8090300@universe-factory.net> Date: Fri, 07 Jun 2013 13:00:52 +0200 From: Matthias Schiffer User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6 MIME-Version: 1.0 To: David Miller CC: xiyou.wangcong@gmail.com, kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net/3.9] ipv6: ndisc: fix ndisc_send_redirect writing to the wrong skb References: <51A66CF3.7010202@universe-factory.net> <5578958b49fff222740711e091c2325100f5a440.1369963643.git.mschiffer@universe-factory.net> <20130531.014244.1871655049070137342.davem@davemloft.net> In-Reply-To: <20130531.014244.1871655049070137342.davem@davemloft.net> X-Enigmail-Version: 1.5.1 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="----enig2MFPEVCVABNCPCGVIDOJI" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1758 Lines: 51 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2MFPEVCVABNCPCGVIDOJI Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 05/31/2013 10:42 AM, David Miller wrote: > From: Cong Wang > Date: Fri, 31 May 2013 11:23:11 +0800 >=20 >> On Fri, May 31, 2013 at 9:27 AM, Matthias Schiffer >> wrote: >>> Since some refactoring in 5f5a011, ndisc_send_redirect called >>> ndisc_fill_redirect_hdr_option on the wrong skb, leading to data corr= uption or >>> in the worst case a panic when the skb_put failed. >>> >>> Signed-off-by: Matthias Schiffer >> >> >> Good catch! >> >> Reviewed-by: Cong Wang >=20 > I've queued this up for -stable. >=20 I saw that this was marked as 'not applicable' in the patchwork - it should still be applied to the net tree though. I hope my patch tag 'net/3.9' didn't cause any confusion, I meant net *and* 3.9. ------enig2MFPEVCVABNCPCGVIDOJI Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.20 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iEYEARECAAYFAlGxvWQACgkQq3qIxbiQM9jQDQCeOhCY5fZEloQgamjoNpkEh2L5 tdkAn1Wk+/FLQBrDZ4wrVzPnieLb/LZ8 =Eii2 -----END PGP SIGNATURE----- ------enig2MFPEVCVABNCPCGVIDOJI-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/