MIME-Version: 1.0
In-Reply-To: <1370606855-19403-1-git-send-email-patrice.chotard.st@gmail.com>
References: <1370606855-19403-1-git-send-email-patrice.chotard.st@gmail.com>
Date: Fri, 7 Jun 2013 15:00:38 +0200
Message-ID: <CACRpkdbixv21db-_TcPApRj7=BHCQ52TDXnHqMpn+kaXcBBrhA@mail.gmail.com>
Subject: Re: [PATCH] pinctrl: pinctrl-abx500: Add device tree support
From: Linus Walleij <linus.walleij@linaro.org>
To: Patrice Chotard <patrice.chotard.st@gmail.com>,
        =?ISO-8859-1?Q?Heiko_St=FCbner?= <heiko@sntech.de>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Olivier Clergeaud <olivier.clergeaud@st.com>,
        Lee Jones <lee.jones@linaro.org>,
        Fabio Baltieri <fabio.baltieri@linaro.org>,
        Patrice Chotard <patrice.chotard@st.com>,
        Gabriel Fernandez <gabriel.fernandez@st.com>
Content-Type: text/plain; charset=ISO-8859-1
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1647
Lines: 50

On Fri, Jun 7, 2013 at 2:07 PM,  <patrice.chotard.st@gmail.com> wrote:

> From: Patrice Chotard <patrice.chotard@st.com>
>
> We use the same way to define pin muxing and pin
> configuration than for nomadik. So pickup code
> from pinctrl_nomadik.c to be able to implement
> pin multiplexing and pin configuration using
> the device tree.
>
> Signed-off-by: Gabriel Fernandez <gabriel.fernandez@st.com>
> Signed-off-by: Patrice Chotard <patrice.chotard@st.com>

Overall this is looking fine.

> +- ste,config: Handle of pin configuration node (e.g. ste,config = <&slpm_in_wkup_pdis>)
> +
> +- ste,input : <0/1/2>
> +       0: input with no pull
> +       1: input with pull up,
> +       2: input with pull down,
> +
> +- ste,output: <0/1/2>
> +       0: output low,
> +       1: output high,
> +       2: output (value is not specified).

As I have just discussed with Heiko, we need generic pin config bindings for
the drivers using generic pin config, such as the abx500. We have to start
unifying unifiable stuff...

i.e. this is not similar to the Nomadik pinctrl driver, because that one is not
using generic pin config.

So we're trying to agree on generic bindings with generic parsing code to
avoid code duplication.

Please check my review of Heiko's patch for my ideas and comment in
that thread.

Subject:
"[PATCH v2 5/8] pinctrl: add pinctrl driver for Rockchip SoCs"

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/