From: Matthew Garrett <matthew.garrett@nebula.com>
To: Adam Lee <adam.lee@canonical.com>
CC: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "platform-driver-x86@vger.kernel.org" 
	<platform-driver-x86@vger.kernel.org>,
        "ibm-acpi-devel@lists.sourceforge.net" 
	<ibm-acpi-devel@lists.sourceforge.net>,
        Henrique de Moraes Holschuh <ibm-acpi@hmh.eng.br>,
        Alex Hung <alex.hung@canonical.com>, Bjorn Mork <bjorn@mork.no>
Subject: Re: [PATCH 3/3] thinkpad_acpi: add LED quirks of models which don't
 have EC controllable LEDs
Thread-Topic: [PATCH 3/3] thinkpad_acpi: add LED quirks of models which
 don't have EC controllable LEDs
Thread-Index: AQHOY1gzmacRmhLkTEmhzaeIETItNpkqPXgA
Date: Fri, 7 Jun 2013 13:22:39 +0000
Message-ID: <1370611358.6315.48.camel@x230.lan>
References: <1370593209-21358-1-git-send-email-adam.lee@canonical.com>
	 <1370593209-21358-4-git-send-email-adam.lee@canonical.com>
In-Reply-To: <1370593209-21358-4-git-send-email-adam.lee@canonical.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="utf-8"
Content-ID: <3CE83064782ADE48B7EF93A328CBD754@namprd05.prod.outlook.com>
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Transfer-Encoding: 8bit
Content-Length: 559
Lines: 11

On Fri, 2013-06-07 at 16:20 +0800, Adam Lee wrote:
> Some new Lenovo or ThinkPad laptops don't have EC controllable LEDs.
> This patch adds their quirks.

Can you detect this case? If this is a new way of doing things then
you're going to have to add new entries to the quirk list every time
Lenovo release a new machine, which isn't really going to work.

-- 
Matthew Garrett | mjg59@srcf.ucam.org
????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m????????????I?