Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755373Ab3FGOQR (ORCPT ); Fri, 7 Jun 2013 10:16:17 -0400 Received: from forward-corp1f.mail.yandex.net ([95.108.130.40]:51607 "EHLO forward-corp1f.mail.yandex.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753556Ab3FGOQN (ORCPT ); Fri, 7 Jun 2013 10:16:13 -0400 Authentication-Results: smtpcorp4.mail.yandex.net; dkim=pass header.i=@yandex-team.ru Message-ID: <51B1EB25.9000509@yandex-team.ru> Date: Fri, 07 Jun 2013 18:16:05 +0400 From: Roman Gushchin User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 MIME-Version: 1.0 To: Johannes Weiner CC: linux-mm@kvack.org, Andi Kleen , Andrea Arcangeli , Andrew Morton , Greg Thelen , Christoph Hellwig , Hugh Dickins , Jan Kara , KOSAKI Motohiro , Mel Gorman , Minchan Kim , Peter Zijlstra , Rik van Riel , Michel Lespinasse , Seth Jennings , metin d , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [patch 09/10] mm: thrash detection-based file cache sizing References: <1369937046-27666-1-git-send-email-hannes@cmpxchg.org> <1369937046-27666-10-git-send-email-hannes@cmpxchg.org> In-Reply-To: <1369937046-27666-10-git-send-email-hannes@cmpxchg.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1246 Lines: 34 On 30.05.2013 22:04, Johannes Weiner wrote: > +/* > + * Monotonic workingset clock for non-resident pages. > + * > + * The refault distance of a page is the number of ticks that occurred > + * between that page's eviction and subsequent refault. > + * > + * Every page slot that is taken away from the inactive list is one > + * more slot the inactive list would have to grow again in order to > + * hold the current non-resident pages in memory as well. > + * > + * As the refault distance needs to reflect the space missing on the > + * inactive list, the workingset time is advanced every time the > + * inactive list is shrunk. This means eviction, but also activation. > + */ > +static atomic_long_t workingset_time; It seems strange to me, that workingset_time is global. Don't you want to make it per-cgroup? Two more questions: 1) do you plan to take fadvise's into account somehow? 2) do you plan to use workingset information to enhance the readahead mechanism? Thanks! Regards, Roman -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/