Date: Fri, 7 Jun 2013 11:04:28 -0400
From: Benjamin LaHaise <bcrl@kvack.org>
To: Willy Tarreau <w@1wt.eu>
Cc: Ben Hutchings <ben@decadent.org.uk>, linux-kernel@vger.kernel.org,
        stable@vger.kernel.org,
        Timo =?iso-8859-1?Q?Ter=E4s?= <timo.teras@iki.fi>
Subject: Re: [ 150/184] ipv4: check rt_genid in dst_check
Message-ID: <20130607150352.GS15183@kvack.org>
References: <20130604172136.519104713@1wt.eu> <1370585253.4021.93.camel@deadeye.wl.decadent.org.uk> <20130607145806.GR15183@kvack.org> <20130607150057.GF19006@1wt.eu>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20130607150057.GF19006@1wt.eu>
User-Agent: Mutt/1.4.2.2i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1533
Lines: 36

Hi Willy,

On Fri, Jun 07, 2013 at 05:00:57PM +0200, Willy Tarreau wrote:
> On Fri, Jun 07, 2013 at 10:58:06AM -0400, Benjamin LaHaise wrote:
> > On Fri, Jun 07, 2013 at 07:07:33AM +0100, Ben Hutchings wrote:
> > > > This commit is based on the above, with the addition of verifying blackhole
> > > > routes in the same manner.
> > > 
> > > That addition doesn't seem to correspond to anything in mainline.  Why
> > > should 2.6.32 differ?
> > 
> > Fixing the issue with blackhole routes as it was accomplished in mainline 
> > would require pulling in a lot more code, and people were not interested 
> > in pulling in all of the dependencies given the much higher risk of trying 
> > to select the right subset of changes to include.  The addition of the 
> > single line of "dst->obsolete = -1;" in ipv4_dst_blackhole() was much 
> > easier to verify, and is in the spirit of the patch in question.  This is 
> > the minimal set of changes to fix the bug in question.
> 
> Thank you Ben, I'll add this description to the existing commit message.

A link to the test case for this issue might be helpful to include as well.  
It is at http://marc.info/?l=linux-netdev&m=135015076708950&w=2 .  Cheers,

		-ben

> Best regards,
> Willy

-- 
"Thought is the essence of where you are now."
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/