Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757140Ab3FGSOv (ORCPT ); Fri, 7 Jun 2013 14:14:51 -0400 Received: from mail-la0-f48.google.com ([209.85.215.48]:62862 "EHLO mail-la0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757096Ab3FGSOr (ORCPT ); Fri, 7 Jun 2013 14:14:47 -0400 MIME-Version: 1.0 In-Reply-To: <2536139.bTRcfOkXer@flatron> References: <1370580406-10254-1-git-send-email-dianders@chromium.org> <1370626110-1731-1-git-send-email-dianders@chromium.org> <2536139.bTRcfOkXer@flatron> Date: Fri, 7 Jun 2013 11:14:44 -0700 X-Google-Sender-Auth: wh83B8BSElfbwpJLySeIiBT_Lig Message-ID: Subject: Re: [PATCH v2 1/2] mmc: dw_mmc: Handle late vmmc regulators with EPROBE_DEFER From: Doug Anderson To: Tomasz Figa Cc: Chris Ball , Olof Johansson , Andrew Bresticker , Alim Akhtar , Abhilash Kesavan , Jaehoon Chung , Seungwon Jeon , Grant Likely , Rob Herring , Rob Landley , Will Newton , "devicetree-discuss@lists.ozlabs.org" , linux-doc@vger.kernel.org, "linux-kernel@vger.kernel.org" , "linux-mmc@vger.kernel.org" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1150 Lines: 28 Tomasz, On Fri, Jun 7, 2013 at 10:42 AM, Tomasz Figa wrote: > A question just out of curiousity: Is it really correct to have one vmmc > regulator for the whole device, instead of one regulator per slot? > > This might be something obvious, but I don't know any details about > dw_mmc, so sorry if it's the case. I don't actually know. I've never seen a multi-slot implementation so I end up doing lots of speculation when I make changes. Certainly the code I'm moving wouldn't have worked correctly in the more-than-one-slot case. There's only space to pass one regulator (it's not per-slot) and that one regulator would have just been enabled multiple times. ...and it would have only been disabled once in places like suspend/resume. If there is every a multi-slot implementation that needs vmmc on a per-slot it seems like we could address at that time? Thanks! -Doug -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/