Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751813Ab3FHJEp (ORCPT ); Sat, 8 Jun 2013 05:04:45 -0400 Received: from mail-pb0-f43.google.com ([209.85.160.43]:47423 "EHLO mail-pb0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751507Ab3FHJEm (ORCPT ); Sat, 8 Jun 2013 05:04:42 -0400 Date: Sat, 8 Jun 2013 17:04:33 +0800 From: Adam Lee To: Henrique de Moraes Holschuh Cc: Matthew Garrett , linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, ibm-acpi-devel@lists.sourceforge.net, Alex Hung , Bjorn Mork Subject: Re: [PATCH 3/3] thinkpad_acpi: add LED quirks of models which don't have EC controllable LEDs Message-ID: <20130608090433.GB7334@adam-laptop> Mail-Followup-To: Henrique de Moraes Holschuh , Matthew Garrett , linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, ibm-acpi-devel@lists.sourceforge.net, Alex Hung , Bjorn Mork References: <1370593209-21358-1-git-send-email-adam.lee@canonical.com> <1370593209-21358-4-git-send-email-adam.lee@canonical.com> <1370611358.6315.48.camel@x230.lan> <20130607150651.GA2227@adam-laptop> <1370636175.13515.140661241274985.19126A97@webmail.messagingengine.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1370636175.13515.140661241274985.19126A97@webmail.messagingengine.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1192 Lines: 27 On Fri, Jun 07, 2013 at 05:16:15PM -0300, Henrique de Moraes Holschuh wrote: > Can you get me the ACPI interface documentation? It should be simple > to get it, but I haven't emailed the Lenovo BIOS engineers for some > time. > > Basically, create a new LED method in thinkpad-acpi, lock it down to > vendor lenovo, detect the new interfaces, and only check the > two-argument LED one if the newer ones aren't found. > > Not supporting the old /proc interface on new thinkpads is fine. Thanks, I will request the documentation from Lenovo again. Please apply "[PATCH 1/3 v3] thinkpad_acpi: return -NODEV while operating uninitialized LEDs" and "[PATCH 2/3] thinkpad_acpi: add the ability setting TPACPI_LED_NONE by quirk", but hold "[PATCH 3/3] thinkpad_acpi: add LED quirks of models which don't have EC controllable LEDs", I will drop [PATCH 3/3] to discussion again when I got the documentation. -- Regards, Adam Lee Hardware Enablement -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/