Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752241Ab3FHKtR (ORCPT ); Sat, 8 Jun 2013 06:49:17 -0400 Received: from mail-bk0-f44.google.com ([209.85.214.44]:63786 "EHLO mail-bk0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752074Ab3FHKtQ (ORCPT ); Sat, 8 Jun 2013 06:49:16 -0400 From: Tomasz Figa To: Tushar Behera Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, kgene.kim@samsung.com, patches@linaro.org, Sachin Kamat Subject: Re: [PATCH 2/3] ARM: dts: Add FIMD node to Origen4210 board Date: Sat, 08 Jun 2013 12:49:10 +0200 Message-ID: <5527415.fcM1OgADxD@flatron> User-Agent: KMail/4.10.4 (Linux/3.9.5-gentoo; KDE/4.10.4; x86_64; ; ) In-Reply-To: <1370603235-11193-3-git-send-email-tushar.behera@linaro.org> References: <1370603235-11193-1-git-send-email-tushar.behera@linaro.org> <1370603235-11193-3-git-send-email-tushar.behera@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1689 Lines: 59 On Friday 07 of June 2013 16:37:14 Tushar Behera wrote: > From: Sachin Kamat > > Added FIMD and display timing node to Origen4210 board. > > Signed-off-by: Sachin Kamat > Signed-off-by: Tushar Behera > --- > arch/arm/boot/dts/exynos4210-origen.dts | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) > > diff --git a/arch/arm/boot/dts/exynos4210-origen.dts > b/arch/arm/boot/dts/exynos4210-origen.dts index bcf8079..4c6c3cd 100644 > --- a/arch/arm/boot/dts/exynos4210-origen.dts > +++ b/arch/arm/boot/dts/exynos4210-origen.dts > @@ -290,4 +290,25 @@ > clock-frequency = <24000000>; > }; > }; > + > + fimd@11c00000 { > + pinctrl-0 = <&lcd_en &lcd_clk &lcd_data24 &pwm0_out>; Ahh, this would explain the two pwm pin groups from previous patch. This seems somehow incorrect, though. AFAIK PWM outputs are not managed by FIMD in any way. > + pinctrl-names = "default"; > + status = "okay"; > + }; > + > + display-timings { > + native-mode = <&timing0>; > + timing0: timing { > + clock-frequency = <50000>; Hmm, 50 KHz for pixel clock? Isn't it a bit too low? Or am I missing something? Best regards, Tomasz > + hactive = <1024>; > + vactive = <600>; > + hfront-porch = <64>; > + hback-porch = <16>; > + hsync-len = <48>; > + vback-porch = <64>; > + vfront-porch = <16>; > + vsync-len = <3>; > + }; > + }; > }; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/