Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754197Ab3FIQJC (ORCPT ); Sun, 9 Jun 2013 12:09:02 -0400 Received: from mail-oa0-f43.google.com ([209.85.219.43]:64617 "EHLO mail-oa0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753182Ab3FIQJA (ORCPT ); Sun, 9 Jun 2013 12:09:00 -0400 MIME-Version: 1.0 In-Reply-To: References: Date: Sun, 9 Jun 2013 19:09:00 +0300 Message-ID: Subject: Re: [PATCH] pcmcia: pd6729: fix error return code in pd6729_pci_probe() From: Andy Shevchenko To: Wei Yongjun Cc: Bill Pemberton , Greg Kroah-Hartman , Eric Miao , yongjun_wei@trendmicro.com.cn, linux-pcmcia@lists.infradead.org, "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 588 Lines: 16 On Fri, Jun 7, 2013 at 5:16 AM, Wei Yongjun wrote: > From: Wei Yongjun > > Fix to return a negative error code from the error handling > case instead of 0, as done elsewhere in this function. What about to move the driver to pcim_*/devm_* functions? -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/