Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751703Ab3FIVP0 (ORCPT ); Sun, 9 Jun 2013 17:15:26 -0400 Received: from mail-oa0-f45.google.com ([209.85.219.45]:42217 "EHLO mail-oa0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751273Ab3FIVPY (ORCPT ); Sun, 9 Jun 2013 17:15:24 -0400 MIME-Version: 1.0 In-Reply-To: <20130609205747.GX23987@mwanda> References: <1370768902-20239-1-git-send-email-emilgoode@gmail.com> <20130609191732.GK28112@mwanda> <20130609205747.GX23987@mwanda> Date: Mon, 10 Jun 2013 00:15:22 +0300 Message-ID: Subject: Re: [PATCH] mtd: orion_nand: Improve error handling in orion_nand_probe From: Andy Shevchenko To: Dan Carpenter Cc: Emil Goode , David Woodhouse , artem.bityutskiy@linux.intel.com, andrew@lunn.ch, Bill Pemberton , Jingoo Han , linux-mtd@lists.infradead.org, "linux-kernel@vger.kernel.org" , kernel-janitors@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1333 Lines: 36 On Sun, Jun 9, 2013 at 11:57 PM, Dan Carpenter wrote: > On Sun, Jun 09, 2013 at 10:27:03PM +0300, Andy Shevchenko wrote: >> On Sun, Jun 9, 2013 at 10:17 PM, Dan Carpenter wrote: >> > On Sun, Jun 09, 2013 at 08:15:20PM +0300, Andy Shevchenko wrote: >> >> What about another patch (that I guess should go first) that converts >> >> printk to dev_* or pr_*? >> >> > Huh, what? Those are two totally unrelated things. Emil's patch is >> > a bug fix. >> >> To be precise his patch is bugfix and cleanup at once. >> My proposal is to add a clean up patch. > > The printk idea isn't a bad one, it's just totally unrelated to what > the patch is doing. I don't agree with word 'totally'. It touches probe function and shuffles code there. > You can't just randomly tell people to do a > bunch of work for no reason. "Good bugfix, but before we apply it > you have to mow my lawn." In this particular case I didn't think it's a big deal to fix 3 printfs. Anyway, see patch in the next message. -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/