Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751494Ab3FJEQb (ORCPT ); Mon, 10 Jun 2013 00:16:31 -0400 Received: from mail-pd0-f169.google.com ([209.85.192.169]:34454 "EHLO mail-pd0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750812Ab3FJEQa (ORCPT ); Mon, 10 Jun 2013 00:16:30 -0400 Message-ID: <51B55319.7090603@linaro.org> Date: Mon, 10 Jun 2013 09:46:25 +0530 From: Tushar Behera User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 MIME-Version: 1.0 To: linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org CC: mturquette@linaro.org, kgene.kim@samsung.com, patches@linaro.org Subject: Re: [PATCH] clk: exynos5250: Add CLK_IGNORE_UNUSED flag for pmu clock References: <1370507298-9230-1-git-send-email-tushar.behera@linaro.org> In-Reply-To: <1370507298-9230-1-git-send-email-tushar.behera@linaro.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1761 Lines: 40 On 06/06/2013 01:58 PM, Tushar Behera wrote: > Currently 'pmu' clock is not handled by any of the drivers. > Also before the introduction of CCF, this clock was not defined, > hence was left enabled always. > > When this clock is disabled, software reset register becomes > inaccessible and system reboot doesn't work. > > Upon restoring the default behaviour, system reboot starts working. > > Signed-off-by: Tushar Behera > --- > drivers/clk/samsung/clk-exynos5250.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/samsung/clk-exynos5250.c b/drivers/clk/samsung/clk-exynos5250.c > index 5c97e75..3853da9 100644 > --- a/drivers/clk/samsung/clk-exynos5250.c > +++ b/drivers/clk/samsung/clk-exynos5250.c > @@ -378,7 +378,7 @@ struct samsung_gate_clock exynos5250_gate_clks[] __initdata = { > GATE(hsi2c3, "hsi2c3", "aclk66", GATE_IP_PERIC, 31, 0, 0), > GATE(chipid, "chipid", "aclk66", GATE_IP_PERIS, 0, 0, 0), > GATE(sysreg, "sysreg", "aclk66", GATE_IP_PERIS, 1, 0, 0), > - GATE(pmu, "pmu", "aclk66", GATE_IP_PERIS, 2, 0, 0), > + GATE(pmu, "pmu", "aclk66", GATE_IP_PERIS, 2, CLK_IGNORE_UNUSED, 0), > GATE(tzpc0, "tzpc0", "aclk66", GATE_IP_PERIS, 6, 0, 0), > GATE(tzpc1, "tzpc1", "aclk66", GATE_IP_PERIS, 7, 0, 0), > GATE(tzpc2, "tzpc2", "aclk66", GATE_IP_PERIS, 8, 0, 0), > If there are no objections, can this patch be queued for 3.10? It is fixing regression w.r.t. system reboot on EXYNOS5250 based systems. -- Tushar Behera -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/