Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753185Ab3FJJff (ORCPT ); Mon, 10 Jun 2013 05:35:35 -0400 Received: from kdh-gw.itdev.co.uk ([89.21.227.133]:19557 "EHLO hermes.kdh.itdev.co.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752485Ab3FJJfe (ORCPT ); Mon, 10 Jun 2013 05:35:34 -0400 Message-ID: <51B59DE3.2000907@itdev.co.uk> Date: Mon, 10 Jun 2013 10:35:31 +0100 From: Nick Dyer User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 MIME-Version: 1.0 To: Yufeng Shen CC: Dmitry Torokhov , Daniel Kurtz , Henrik Rydberg , Joonyoung Shim , Alan Bowens , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Peter Meerwald , Benson Leung , Olof Johansson Subject: Re: [PATCH 44/53] Input: atmel_mxt_ts - Verify Information Block checksum on probe References: <1370453866-16534-1-git-send-email-nick.dyer@itdev.co.uk> <1370453866-16534-45-git-send-email-nick.dyer@itdev.co.uk> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 884 Lines: 21 Yufeng Shen wrote: >> + dev_info(&client->dev, >> + "Family: %u Variant: %u Firmware V%u.%u.%02X Objects: %u\n", >> + info->family_id, info->variant_id, info->version >> 4, >> + info->version & 0xf, info->build, info->object_num); >> + > > Use data->info->XXX here, info was pointing to buf which could have > changed after krealloc. Thank you, that's a really good spot. Caused when I merged the dev_info line into that function. It actually explains a report I had about getting junk in this output but the info_crc check succeeding, hadn't had time to investigate yet. I will fix. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/