Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752698Ab3FJLrs (ORCPT ); Mon, 10 Jun 2013 07:47:48 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:55905 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751843Ab3FJLrq convert rfc822-to-8bit (ORCPT ); Mon, 10 Jun 2013 07:47:46 -0400 From: "Philip, Avinash" To: Linus Walleij CC: "Nori, Sekhar" , ext Kevin Hilman , Russell King - ARM Linux , Grant Likely , "linux-arm-kernel@lists.infradead.org" , "davinci-linux-open-source@linux.davincidsp.com" , "linux-kernel@vger.kernel.org" , "KV, Sujith" , Rob Herring , Rob Landley , "devicetree-discuss@lists.ozlabs.org" , "linux-doc@vger.kernel.org" Subject: RE: [PATCH 09/11] gpio: davinci: DT changes for driver Thread-Topic: [PATCH 09/11] gpio: davinci: DT changes for driver Thread-Index: AQHOVrudmCJF1gtQjUmjLzYh/6/VjZkdkoMAgBEOdXA= Date: Mon, 10 Jun 2013 11:45:59 +0000 Deferred-Delivery: Mon, 10 Jun 2013 11:46:00 +0000 Message-ID: <518397C60809E147AF5323E0420B992E3EAD9928@DBDE04.ent.ti.com> References: <1369206634-6778-1-git-send-email-avinashphilip@ti.com> <1369206634-6778-10-git-send-email-avinashphilip@ti.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.24.170.142] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1797 Lines: 60 On Thu, May 30, 2013 at 23:55:22, Linus Walleij wrote: > On Wed, May 22, 2013 at 9:10 AM, Philip Avinash wrote: > > (...) > > +- interrupts: The Starting IRQ number for GPIO > > +- intc_irq_num: The number of IRQs supported by the Interrupt Controller > (...) > > No this is not how you pass a number of IRQs in the device tree. > > "interrupts" is an array. Pass every interrupt here for a full > resolution of the IRQs. Correct. I will change. > > Further this looks fishy: > > + interrupts = <42>; > > Usually you pass flags with the IRQs, I would rather have expected > an array like this: > > interrupts = < 90 0x4 96 0x4 14 0x4 15 0x4 79 0x4>; > > 0x4 is IRQ_TYPE_LEVEL_HIGH, you can use the dts > #include and > define that symbolically. > > Doesn't the DaVinci IRQ controller support *any* IRQ flags? I wasn't sure about it. But from davinci GPIO driver perspective, GPIO pins are configured as edge sensitive. So IRQ_TYPE_EDGE_BOTH can be used. So I will correct Documentation and update DT nodes in next version. > > Since the driver code is not reading out the interrupts but > (I guess?) falling back to platform data IRQ assignment, > this seems wrong. Driver code reads "Starting IRQ number for GPIO" from platform resource See [PATCH 03/11] gpio: davinci: Modify to platform driver. Driver requires only starting offset of gpio irq number. GPIO interrupt Number expected in sequential order for davinci GPIO. Thanks Avinash > Yours, > Linus Walleij > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/