Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752408Ab3FJMzg (ORCPT ); Mon, 10 Jun 2013 08:55:36 -0400 Received: from mail.skyhub.de ([78.46.96.112]:52011 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751034Ab3FJMze (ORCPT ); Mon, 10 Jun 2013 08:55:34 -0400 Date: Mon, 10 Jun 2013 14:55:30 +0200 From: Borislav Petkov To: Matt Fleming Cc: "H. Peter Anvin" , Linux EFI , Matthew Garrett , Jiri Kosina , X86-ML , LKML , Borislav Petkov Subject: Re: [PATCH 4/4] x86, efi: Map runtime services 1:1 Message-ID: <20130610125530.GA11673@pd.tnic> References: <1370177770-26661-1-git-send-email-bp@alien8.de> <1370177770-26661-5-git-send-email-bp@alien8.de> <20130606131439.GI30420@console-pimps.org> <20130606132908.GE20972@pd.tnic> <20130606155822.GH20972@pd.tnic> <51B0E2D4.3040007@zytor.com> <20130606193612.GM20972@pd.tnic> <51B0E522.4070005@zytor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <51B0E522.4070005@zytor.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1368 Lines: 37 On Thu, Jun 06, 2013 at 12:38:10PM -0700, H. Peter Anvin wrote: > On 06/06/2013 12:36 PM, Borislav Petkov wrote: > > On Thu, Jun 06, 2013 at 12:28:20PM -0700, H. Peter Anvin wrote: > >> Or we could materialize mappings for this specific PGD. However, > >> adding a read of %cr3 in __do_page_fault sounds expensive. > > > > Yes, I think we want to make sure all mappings are there when we do an > > EFI runtime call so that we never #PF while it executes. > > > > Matt mentioned on IRC that the it could be that his EFI runtime is > > referencing EFI_RESERVED area which we don't map. However, we need to > > confirm/disprove that first, as it is currently only a hunch. FWIW, booting the patchset on my Dell looks good here. Booting at least, I don't know about other stuff. If you have an EFI test suite or want me to try stuff out, let me know. efibootmgr output looks sane too. Btw, I've added a printk to the code so that we know that we've managed switching to the 1:1 thing: [ 0.073119] efi: Using 1:1 map. Thanks. -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/